Skip to content

The VideoPress mime-type is missing#7167

Merged
dereksmart merged 1 commit intomasterfrom
fix/add-videopress-mime-ext
May 12, 2017
Merged

The VideoPress mime-type is missing#7167
dereksmart merged 1 commit intomasterfrom
fix/add-videopress-mime-ext

Conversation

@dbtlr
Copy link
Copy Markdown
Contributor

@dbtlr dbtlr commented May 11, 2017

VideoPress attachments are currently added in as a mime-type of video/videopress. This is primarily so that we can delineate the difference between these, virtual entries, and the other types of video files that might be present.

Currently, we do not declare this mime-type as a video file to WordPress so when pulling up the media library for videos projects like the new Core Media Widgets are having problems seeing and uploading videos when VideoPress is enabled.

This PR adds in the mime type video/videopress to the upload_mimes and wp_video_extensions filters, which fixes this gap.

Note: This is a blocker for getting the Core Media Widgets feature plugin working. Can we please get this out with the next bug fix release?

Testing

  • After loading this PR, go to the Media Library and view page source.
  • Search for the term mimeTypes
  • You should find the video/videopress type now listed, like this:

screen shot 2017-05-11 at 12 00 23 pm

@dbtlr dbtlr added [Feature] VideoPress A feature to help you upload and insert videos on your site. [Pri] BLOCKER [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended [Type] Quick Fix labels May 11, 2017
@dbtlr dbtlr requested review from jeherve and zinigor May 11, 2017 04:06
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my tests! 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 11, 2017
@dereksmart dereksmart merged commit c07cf06 into master May 12, 2017
@dereksmart dereksmart deleted the fix/add-videopress-mime-ext branch May 12, 2017 19:53
@dereksmart dereksmart removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 12, 2017
@dereksmart
Copy link
Copy Markdown
Contributor

@dbtlr There is no plan for any point release currently, but our next release is scheduled to land a few days before WP 4.8, and will include this fix.

jeherve added a commit that referenced this pull request May 23, 2017
jeherve added a commit that referenced this pull request May 29, 2017
eliorivero pushed a commit that referenced this pull request May 30, 2017
* Changelog: first pass at a changelog for 5.0

* Changelog: delete 4.9 testing list.

* Changelog: update minimum WP version to match ver. in jetpack.php

Fixes #7158

* Changelog: add #6051

* Changelog: add #6753

* Changelog: add #6928

* Changelog: add #6964

* Changelog: add #7014

* Changelog: add #7057

* Changelog: add #7060

* Changelog: add #7068

* Changelog: add #7070

* Changelog: add #7072

* Changelog: add #7071

* Changelog: add release date and post shortlink.

* Changelog: add #7094

* Changelog: add #7100

* Changelog: add #7108

* Changelog: add #7113

* Changelog: add #7123

* Changelog: add #7135

* Changelog: add #7143

* Changelog: add #7151

* Changelog: add #6996

* Changelog: add #7105

* Changelog: add #7132

* Changelog: add #7166

* Changelog: fix typo in 4.9 changelog.

* Changelog: remove older releases' changelogs.

@see p1HpG7-42e-p2

* Changelog: add #7090

* Changelog: add #7095

* Changelog: add #7112

* Changelog: add #7115

* Changelog: add #7122

* Changelog: add #7137

* Changelog: add #7138

* Changelog: add #7140

* Changelog: add #7154

* Changelog: add ##7155

* Changelog: add #7163

* Changelog: add #7167

* Changelog: add #7171

* Changelog: add #7180

* Changelog: add #7181

* Changelog: add #7183

* Changelog: add #7184

* Changelog: add #7189

* Changelog: add #7191

* Changelog: add #7193

* Changelog: add #7198

* Changelog: add #7200

* Changelog: add #7209

* Changelog: add #7212

* Testing list: add instructions for #7115

* Changelog: add #7188

* Changelog: add #7205

* Changelog: add #7225

* Changelog: add #6872

* Changelog: add #7107

* Changelog: add #7118

* Changelog: add #7142

* Changelog: add #7170

* Changelog: add #7210

* Changelog: add #7218

* Changelog: add #7232

* Changelog: add #7211

* Changelog: add #7213

* Changelog: add #7229

* Changelog: add #7230

* Changelog: add #7214

* Draft changelog for 5.0

* Changelog updates: 2nd pass at a clearer changelog.

- Fix typos.
- Use consistent tense and tone across all changelog.
- Remove unclear items.

* Changelog: add #7026

* Changelog: add #7058

* Changelog: add #7125

* Changelog: add #7249

* Changelog: add #7185

* add mentions of image widget migration

* Changelog: add info about new output for CLI command.

* Changelog: add WP version number matching the new Image Widget.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] VideoPress A feature to help you upload and insert videos on your site. [Pri] BLOCKER

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants