Conversation
2bc37b5 to
5e557fe
Compare
671b51b to
79c2937
Compare
29c38ea to
d1b6ade
Compare
|
I'm still trying to wrap my head around all of the changes. Lots of red and green. For some earlier feedback, I have a question. Are we sure that we don't call to get JITMs from the frontend? We'd only want to do that when the |
|
Yeah, I'll double check just to be sure. |
|
Confirmed it will not show on the frontend, should only perform the api call for users on wp-admin. |
1ec2d70 to
cfaa298
Compare
cfaa298 to
a5c6cdc
Compare
|
I am testing by applying D5613-code to my sandbox as well as this PR to my Jetpack site. Here are a couple of things I notice: The notice formatting on the Akismet page looks off: The VaultPress continues to show after each post I publish. This may be happening because each post has a unique ID, but that seems a bit buggy to me. Perhaps this should be in the WPCOM patch, but for the Akismet nudge, it takes me to a Jetpack.com page that tries to sell me a plan, but I already have a personal plan for this site. I would expect the primary button to either take me to Note: This is the same for VaultPress. I get taken to a Jetpack.com page that expects me to buy a personal plan, but I already have a personal plan. |
class.jetpack.php
Outdated
There was a problem hiding this comment.
@jeffgolenski Just want to double check that we're good to change this since I assume it's used in multiple places.
There was a problem hiding this comment.
hmm, yeah, if it's just for jitms, it can be moved easily.
50b2036 to
4b9365a
Compare
|
JITM translation fix is in another PR: #5535 |
|
I propose we move this forward then. |
* Changelog: first pass at a changelog for 5.0 * Changelog: delete 4.9 testing list. * Changelog: update minimum WP version to match ver. in jetpack.php Fixes #7158 * Changelog: add #6051 * Changelog: add #6753 * Changelog: add #6928 * Changelog: add #6964 * Changelog: add #7014 * Changelog: add #7057 * Changelog: add #7060 * Changelog: add #7068 * Changelog: add #7070 * Changelog: add #7072 * Changelog: add #7071 * Changelog: add release date and post shortlink. * Changelog: add #7094 * Changelog: add #7100 * Changelog: add #7108 * Changelog: add #7113 * Changelog: add #7123 * Changelog: add #7135 * Changelog: add #7143 * Changelog: add #7151 * Changelog: add #6996 * Changelog: add #7105 * Changelog: add #7132 * Changelog: add #7166 * Changelog: fix typo in 4.9 changelog. * Changelog: remove older releases' changelogs. @see p1HpG7-42e-p2 * Changelog: add #7090 * Changelog: add #7095 * Changelog: add #7112 * Changelog: add #7115 * Changelog: add #7122 * Changelog: add #7137 * Changelog: add #7138 * Changelog: add #7140 * Changelog: add #7154 * Changelog: add ##7155 * Changelog: add #7163 * Changelog: add #7167 * Changelog: add #7171 * Changelog: add #7180 * Changelog: add #7181 * Changelog: add #7183 * Changelog: add #7184 * Changelog: add #7189 * Changelog: add #7191 * Changelog: add #7193 * Changelog: add #7198 * Changelog: add #7200 * Changelog: add #7209 * Changelog: add #7212 * Testing list: add instructions for #7115 * Changelog: add #7188 * Changelog: add #7205 * Changelog: add #7225 * Changelog: add #6872 * Changelog: add #7107 * Changelog: add #7118 * Changelog: add #7142 * Changelog: add #7170 * Changelog: add #7210 * Changelog: add #7218 * Changelog: add #7232 * Changelog: add #7211 * Changelog: add #7213 * Changelog: add #7229 * Changelog: add #7230 * Changelog: add #7214 * Draft changelog for 5.0 * Changelog updates: 2nd pass at a clearer changelog. - Fix typos. - Use consistent tense and tone across all changelog. - Remove unclear items. * Changelog: add #7026 * Changelog: add #7058 * Changelog: add #7125 * Changelog: add #7249 * Changelog: add #7185 * add mentions of image widget migration * Changelog: add info about new output for CLI command. * Changelog: add WP version number matching the new Image Widget.











Justin Time Messages
Requires:D5613-codeto be available firstshipped.Uses an API to determine which JITM to show. At first it may seem like a bad idea to have an ajax call fire on every wp-admin page view. However, the call is extremely lightweight if there is not JITM defined for a page, bailing out nearly instantly.
It's designed to cache a call for 5 minutes by default (unless the JITM being shown sets something differently). If a sync occurs (
last_heartbeatoption, also adds alast_syncoption) it will disregard the cache. This is useful in the case where a user clicks a CTA on a JITM or causes some action that would hide the JITM. Such as enabling Akismet. This seems to trigger a heartbeat instantly and we invalidate the cache. I'm open to any and all suggestions about making this more reliable and resilient.Currently waiting on JITMS: adding new JITM styles #7117Testing instructions:
You'll need D5613-code, see that testing plan as well.yarn buildmasterbehavior)product_class(if one VaultPress is dismissed, all of them do)Existing JITMs:
Proposed changelog entry for your changes:
N/A