Surface all modules on search and allow "one-way" activation. #7183
Merged
eliorivero merged 2 commits intomasterfrom May 16, 2017
Merged
Surface all modules on search and allow "one-way" activation. #7183eliorivero merged 2 commits intomasterfrom
eliorivero merged 2 commits intomasterfrom
Conversation
c891230 to
fea13b9
Compare
…n searched for them directly
fea13b9 to
ea6f1e3
Compare
jeherve
approved these changes
May 16, 2017
Member
jeherve
left a comment
There was a problem hiding this comment.
It seems to work for me, but I find it a bit confusing that the cards look different from the default cards:
We have 3 different button types here, and 2 different card designs; it makes me wonder if users won't be confused by all these differences.
The same goes with notifications: they're different depending on the type of feature you activate:
I also still think one should be able to deactivate the feature as well, but I suppose that's another discussion, as we're having in #6788.
jeherve
reviewed
May 16, 2017
Member
jeherve
left a comment
There was a problem hiding this comment.
Should Monitor be searchable as well?
| 'enhanced-distribution', | ||
| 'json-api', | ||
| 'latex', | ||
| 'notes', |
Member
There was a problem hiding this comment.
Should Monitor be on that list as well, as folks can activate it when it's been deactivated?
… action. Added to the list
Contributor
Author
|
@jeherve good calls. I modified this to use the same actions as the settings page. We should be working to deprecate the old Also added monitor to the list. |
zinigor
approved these changes
May 16, 2017
Contributor
zinigor
left a comment
There was a problem hiding this comment.
Nicely done! Tested, works as expected, activates modules with no problem, search works with translated strings as well. Let's get this in!
Contributor
|
Works fine, merging. |
This was referenced May 26, 2017
eliorivero
pushed a commit
that referenced
this pull request
May 30, 2017
* Changelog: first pass at a changelog for 5.0 * Changelog: delete 4.9 testing list. * Changelog: update minimum WP version to match ver. in jetpack.php Fixes #7158 * Changelog: add #6051 * Changelog: add #6753 * Changelog: add #6928 * Changelog: add #6964 * Changelog: add #7014 * Changelog: add #7057 * Changelog: add #7060 * Changelog: add #7068 * Changelog: add #7070 * Changelog: add #7072 * Changelog: add #7071 * Changelog: add release date and post shortlink. * Changelog: add #7094 * Changelog: add #7100 * Changelog: add #7108 * Changelog: add #7113 * Changelog: add #7123 * Changelog: add #7135 * Changelog: add #7143 * Changelog: add #7151 * Changelog: add #6996 * Changelog: add #7105 * Changelog: add #7132 * Changelog: add #7166 * Changelog: fix typo in 4.9 changelog. * Changelog: remove older releases' changelogs. @see p1HpG7-42e-p2 * Changelog: add #7090 * Changelog: add #7095 * Changelog: add #7112 * Changelog: add #7115 * Changelog: add #7122 * Changelog: add #7137 * Changelog: add #7138 * Changelog: add #7140 * Changelog: add #7154 * Changelog: add ##7155 * Changelog: add #7163 * Changelog: add #7167 * Changelog: add #7171 * Changelog: add #7180 * Changelog: add #7181 * Changelog: add #7183 * Changelog: add #7184 * Changelog: add #7189 * Changelog: add #7191 * Changelog: add #7193 * Changelog: add #7198 * Changelog: add #7200 * Changelog: add #7209 * Changelog: add #7212 * Testing list: add instructions for #7115 * Changelog: add #7188 * Changelog: add #7205 * Changelog: add #7225 * Changelog: add #6872 * Changelog: add #7107 * Changelog: add #7118 * Changelog: add #7142 * Changelog: add #7170 * Changelog: add #7210 * Changelog: add #7218 * Changelog: add #7232 * Changelog: add #7211 * Changelog: add #7213 * Changelog: add #7229 * Changelog: add #7230 * Changelog: add #7214 * Draft changelog for 5.0 * Changelog updates: 2nd pass at a clearer changelog. - Fix typos. - Use consistent tense and tone across all changelog. - Remove unclear items. * Changelog: add #7026 * Changelog: add #7058 * Changelog: add #7125 * Changelog: add #7249 * Changelog: add #7185 * add mentions of image widget migration * Changelog: add info about new output for CLI command. * Changelog: add WP version number matching the new Image Widget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements @MichaelArestad "one-way activation" suggestion in #6788
This PR adds a new component,
<SearchableModules />, which has a hard-coded list of modules available for search. It's hard-coded, because search already inherits the cards from existing tabs, and has specific settings configs. These features will all be surfaced with the same card style for each, in order to simplify this code.The card is populated with the Name/descriptions from the module headers themselves. We can change the copy of them, if so desired.
If the module is not active, it will show a banner like this:
If the module is active, we'll continue to show the card with the learn more link:
Please test the following (hard-coded) modules that will now appear in search:
Please make sure that you're not able to search these as a non-admin.
Please make sure that they show a disabled card if in dev mode, and the feature requires a connection, JSON API.