Skip to content

Fix/sync get plugin fatal error#4238

Merged
enejb merged 2 commits intomasterfrom
fix/sync-get-plugin-fatal-error
Jun 29, 2016
Merged

Fix/sync get plugin fatal error#4238
enejb merged 2 commits intomasterfrom
fix/sync-get-plugin-fatal-error

Conversation

@enejb
Copy link
Copy Markdown
Member

@enejb enejb commented Jun 28, 2016 •
edited
Loading

Fixes #4233

Changes proposed in this Pull Request:

  • Added documentation for filters
  • Added function exists check to prevent fatal errors.

cc: @jeherve

@enejb enejb added this to the 4.2 milestone Jun 28, 2016
@enejb enejb self-assigned this Jun 28, 2016
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Jun 28, 2016

Thanks! It doesn't look like the Fatal Error reappears with that fix.

@enejb
Copy link
Copy Markdown
Member Author

enejb commented Jun 28, 2016

Glad to hear it. Are you able to reproduce the fatal error? I wasn't able to. Did you get a white screen?
Also was it due to a plugin you were using?

@enejb enejb force-pushed the fix/sync-get-plugin-fatal-error branch from ef8e9ec to 68d5933 Compare June 28, 2016 18:55
enejb added 2 commits June 28, 2016 16:08
@enejb
Sync: Document all_plugins filter.
a1bed22
@enejb
Sync: Add function exists call to make sure that no fatals happen.
a3b82d0 
Since sometimes that data could be sent when the function hasn't been
loaded yet.
Fixes #4233
@enejb enejb force-pushed the fix/sync-get-plugin-fatal-error branch from 68d5933 to a3b82d0 Compare June 28, 2016 23:08
@lezama
Copy link
Copy Markdown
Contributor

lezama commented Jun 29, 2016

Looks good to me, any ideas when could we call our get_plugins() without the other being available?

@gravityrail gravityrail added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jun 29, 2016
@enejb enejb merged commit 6fe0861 into master Jun 29, 2016
@enejb enejb deleted the fix/sync-get-plugin-fatal-error branch June 29, 2016 16:30
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jun 29, 2016
@jeherve jeherve mentioned this pull request May 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@enejb enejb

Labels

[Package] Sync

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@enejb @jeherve @lezama @gravityrail @matticbot