CSS Concat: add authors and Social Icons widgets to concat styles.#10153
Merged
CSS Concat: add authors and Social Icons widgets to concat styles.#10153
Conversation
Collaborator
|
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
kraftbj
approved these changes
Sep 24, 2018
jeherve
added a commit
that referenced
this pull request
Sep 25, 2018
* Readme: add boilerplate for next release, 6.6 * Add 6.5 to the changelog.txt file * Set boilerplate testing list for 6.6 * Readme: update stable tag to 6.5 * Add bullets to 6.5 changelog items * Readme: add link to previous changelogs This will help folks who want to know more about past releases, while keeping the readme.txt short so as to not overwhelm translators and site owners only looking for information about the last release. * Changelog: add information at the top of the changelog file. * Changelog: add #10054 * Changelog: add #10078 * Changelog: add #10079 * Changelog: add #10064 * Changelog: add #10094 * Changelog: add #10096 * Testing list: add more information based on #10087 * Changelog: add #9847 * Changelog: add #10084 * Changelog: add #9918 * Changelog: add #7614 * Changelog: add #10116 * Changelog: add #10108 * Changelog: add #10041 * Changelog: add #10121 * Changelog: add #10134 * Changelog: add #10130 * Changelog: add #10109 * changelog: add #10137 * changelog: add #9952 * changelog: add #10120 * changelog: add #10162 * Changelog: add #10163 * Changelog: add #10092 * changelog: add #10156 * Changelog: add #10154 * changelog: add #10122 * Changelog: add #10101 * changelog: add #10105 * changelog: add #10190 * Changelog: add #10196 * changelog: add #10152 * Changelog: add #10153 * Testing list: add more details to Site Verification testing steps. @see #10143 (comment) * changelog: add #10194 * Changelog: add #10193
jeherve
added a commit
that referenced
this pull request
Oct 9, 2018
Follow up for #10153 The files were not enqueued anymore as of the PR above, but the CSS did not get added to the jetpack.css file that is enqueued instead of the singular files.
jeherve
added a commit
that referenced
this pull request
Oct 9, 2018
* Widgets: concatenate author and Social Icons widget CSS Follow up for #10153 The files were not enqueued anymore as of the PR above, but the CSS did not get added to the jetpack.css file that is enqueued instead of the singular files. * CSS builder: remove authors file since it was already in the list * CSS Concatenation: add comments to avoid issues in the future.
jeherve
added a commit
that referenced
this pull request
Oct 9, 2018
* Widgets: concatenate author and Social Icons widget CSS Follow up for #10153 The files were not enqueued anymore as of the PR above, but the CSS did not get added to the jetpack.css file that is enqueued instead of the singular files. * CSS builder: remove authors file since it was already in the list * CSS Concatenation: add comments to avoid issues in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10009
Changes proposed in this Pull Request:
Do not load the authors and Social Icons widgets' stylesheets separately, whether the widget is on the page or not; instead, load it as part of the
jetpack.cssfile.Testing instructions:
SCRIPT_DEBUGis not set to true on your site.modules/widgets/social-icons/social-icons.cssandmodules/widgets/authors/style.cssfiles are not loaded.Proposed changelog entry for your changes:
CSS Concatenation: add Authors and Social Icons widgets to concatenated styles.