Protect: fix layout of "Prove your humanity" label#9847
Merged
Conversation
b8f34d5 to
3d091a0
Compare
zinigor
approved these changes
Jul 26, 2018
Contributor
zinigor
left a comment
There was a problem hiding this comment.
Code-wise I love this, design-wise too, but the latter part I'd delegate to someone :)
Member
|
@eliorivero it's looking good in english. Can you post some screenshots in japanese and other languages just to verify? |
Member
|
@eliorivero piiiiiiing (see comment above) |
Contributor
Author
|
@jeffgolenski sorry for the missed ping. Here's a screenshot in japanese:
|
3d091a0 to
354abb2
Compare
Collaborator
|
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
Member
|
@eliorivero 🚢 ! |
jeherve
added a commit
that referenced
this pull request
Sep 25, 2018
* Readme: add boilerplate for next release, 6.6 * Add 6.5 to the changelog.txt file * Set boilerplate testing list for 6.6 * Readme: update stable tag to 6.5 * Add bullets to 6.5 changelog items * Readme: add link to previous changelogs This will help folks who want to know more about past releases, while keeping the readme.txt short so as to not overwhelm translators and site owners only looking for information about the last release. * Changelog: add information at the top of the changelog file. * Changelog: add #10054 * Changelog: add #10078 * Changelog: add #10079 * Changelog: add #10064 * Changelog: add #10094 * Changelog: add #10096 * Testing list: add more information based on #10087 * Changelog: add #9847 * Changelog: add #10084 * Changelog: add #9918 * Changelog: add #7614 * Changelog: add #10116 * Changelog: add #10108 * Changelog: add #10041 * Changelog: add #10121 * Changelog: add #10134 * Changelog: add #10130 * Changelog: add #10109 * changelog: add #10137 * changelog: add #9952 * changelog: add #10120 * changelog: add #10162 * Changelog: add #10163 * Changelog: add #10092 * changelog: add #10156 * Changelog: add #10154 * changelog: add #10122 * Changelog: add #10101 * changelog: add #10105 * changelog: add #10190 * Changelog: add #10196 * changelog: add #10152 * Changelog: add #10153 * Testing list: add more details to Site Verification testing steps. @see #10143 (comment) * changelog: add #10194 * Changelog: add #10193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to solve a layout issue that was originally found in japanese. Note how the translation of the string "Prove your humanity" is long and causes the math question to be splitted in two lines.
After a discussion with @naokomc where she stated that this could cause issues in other languages and pointed to
https://translate.wordpress.org/projects/wp-plugins/jetpack/dev/nl/default?filters%5Bterm%5D=Prove+your+humanity%3A&filters%5Buser_login%5D=&filters%5Bstatus%5D=current_or_waiting_or_fuzzy_or_untranslated&filter=Filter&sort%5Bby%5D=priority&sort%5Bhow%5D=desc
https://translate.wordpress.org/projects/wp-plugins/jetpack/dev/ru/default?filters%5Bterm%5D=Prove+your+humanity%3A&filters%5Buser_login%5D=&filters%5Bstatus%5D=current_or_waiting_or_fuzzy_or_untranslated&filter=Filter&sort%5Bby%5D=priority&sort%5Bhow%5D=desc
it became clear that this was an issue that needed to be solved by adapting the layout.
In addition, the text is now a label pointing to the field, and the style follows the WP core style of other fields in the page.
The math fallback now looks like
Changes proposed in this Pull Request:
inputtotextinputCSS class, which is from WP coreTesting instructions:
Enable Protect and in WP login, ensure the layout is correct and everything works.
Proposed changelog entry for your changes:
Protect: fix layout of legend that prompts the user to solve the math fallback so it works better in all languages.