Skip to content

Search: improve upgrade/feature messaging#10137

Merged
gibrown merged 4 commits intomasterfrom
add/improve-search-upgrade-message
Sep 18, 2018
Merged

Search: improve upgrade/feature messaging#10137
gibrown merged 4 commits intomasterfrom
add/improve-search-upgrade-message

Conversation

@gibrown
Copy link
Copy Markdown
Member

@gibrown gibrown commented Sep 14, 2018

Fixes #9747

Makes changes to the upgrade messages. The exact language was iterated on a bit in Automattic/wp-calypso#27059 and this PR has them matching. Similar to that PR I also moved the site search settings further down on the page.

The changes affect the UI in the Jetpack dashboard:

  • Main at a glance page wording changed a little bit when not upgraded
  • On the Settings->Traffic page the wording changed a lot both when activated and not

Screenshots of the new upgrade wording:

screen shot 2018-09-13 at 6 16 20 pm

screen shot 2018-09-13 at 6 15 40 pm

screen shot 2018-09-13 at 6 15 56 pm

@gibrown gibrown added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Status] Needs Design Review Design has been added. Needs a review! [Feature] Search For all things related to Search labels Sep 14, 2018
@gibrown gibrown self-assigned this Sep 14, 2018
@gibrown gibrown requested a review from a team as a code owner September 14, 2018 00:29
@jetpackbot
Copy link
Copy Markdown
Collaborator

Warnings
⚠️

"Testing instructions" are missing for this PR. Please add some

⚠️

"Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS

@joanrho
Copy link
Copy Markdown
Contributor

joanrho commented Sep 14, 2018

@gibrown LGTM, but I just pushed some changes to the labels and descriptive text so we refer to it as Jetpack Search more explicitly. Here are screenshots of my changes:

screen shot 2018-09-13 at 6 59 33 pm

screen shot 2018-09-13 at 6 59 24 pm

^ you'll notice that I missed the header label text (dops-section-header__label-text) under the Traffic tab of Settings. I didn't want to mess around too much with renaming any files, so I'll leave that last one for you to do.

@joanrho joanrho self-requested a review September 14, 2018 01:09
@joanrho joanrho removed the [Status] Needs Design Review Design has been added. Needs a review! label Sep 14, 2018
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Sep 14, 2018

Do we want do update the messaging in the prompt in the Plans page while we are at it?

screenshot 2018-09-14 at 12 31 02

We could also look at the widget's description:

screenshot 2018-09-14 at 12 33 55

Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work. I just have a small comment about one of the links.

Also, not something we can fix in Jetpack but I'll mention it since it is somewhat related: the 2 "get started" buttons on the upgrade page we link to (https://jetpack.com/features/design/elasticsearch-powered-search/) from the upgrade prompts in the traffic settings once your site is connected don't actually do anything. They just link to the #get-started anchor on the page.

I ended up scrolling down to the bottom of the page to click on the "Get Search in Jetpack Professional" button, but that wasn't a successful flow either. It led me to a connect page, although my site is already connected. Since the previous Jetpack.com landing page had my site URL as a query string in the URL, I at least would expect my site to be pre-filled here. Here is the URL:

https://wordpress.com/jetpack/connect/pro?cta_id=btn-singlefeature-jpsearch-02&cta_from=features_design_elasticsearch_powered_search

screenshot 2018-09-14 at 12 24 21

As it is, it is quite difficult to upgrade.
For reference, I was using a Jurassic Ninja site that was running this branch, and that I had just connected to WordPress.com a few minutes earlier. I also had purchased a Premium plan for it.

support={ {
text: __( 'Replaces the default WordPress search with a faster, filterable search experience.' ),
text: __( 'Jetpack Search supports many customizations.' ),
link: 'https://jetpack.com/support/search',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link to the customization support page here? https://jetpack.com/support/search/customize-search/

@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Sep 14, 2018
@joanrho
Copy link
Copy Markdown
Contributor

joanrho commented Sep 14, 2018

@jeherve agree that both the Plans page and widget description should both be updated. Thanks for catching those!

You bring up a great point about the upgrade experience from that jetpack.com page—ideally we'd be able to detect that you were logged in to WPcom and then take you to the Calypso checkout page for the upgrade from Prem to Pro at https://wordpress.com/checkout/SITEURL/professional?site=SITEURL. Is this possible to do from that CTA button? cc @jeffgolenski @sirreal @tyxla for their thoughts on this

@sirreal
Copy link
Copy Markdown
Member

sirreal commented Sep 17, 2018

@joanrho That certainly sounds possible, but I'm not familiar with the Jetpack site and how much work might be involved. I took a quick look at the site and it doesn't appear to be a trivial change. @jeffgolenski is probably better equipped to answer that bit.

@gibrown
Copy link
Copy Markdown
Member Author

gibrown commented Sep 18, 2018

@jeherve good call on the plans page. Fixed. I'm merging this in.

@gibrown gibrown merged commit 537ca21 into master Sep 18, 2018
@kraftbj kraftbj deleted the add/improve-search-upgrade-message branch September 21, 2018 03:16
jeherve added a commit that referenced this pull request Sep 24, 2018
jeherve added a commit that referenced this pull request Sep 25, 2018
* Readme: add boilerplate for next release, 6.6

* Add 6.5 to the changelog.txt file

* Set boilerplate testing list for 6.6

* Readme: update stable tag to 6.5

* Add bullets to 6.5 changelog items

* Readme: add link to previous changelogs

This will help folks who want to know more about past releases,
while keeping the readme.txt short so as to not overwhelm translators and site owners only looking for information about the last release.

* Changelog: add information at the top of the changelog file.

* Changelog: add #10054

* Changelog: add #10078

* Changelog: add #10079

* Changelog: add #10064

* Changelog: add #10094

* Changelog: add #10096

* Testing list: add more information based on #10087

* Changelog: add #9847

* Changelog: add #10084

* Changelog: add #9918

* Changelog: add #7614

* Changelog: add #10116

* Changelog: add #10108

* Changelog: add #10041

* Changelog: add #10121

* Changelog: add #10134

* Changelog: add #10130

* Changelog: add #10109

* changelog: add #10137

* changelog: add #9952

* changelog: add #10120

* changelog: add #10162

* Changelog: add #10163

* Changelog: add #10092

* changelog: add #10156

* Changelog: add #10154

* changelog: add #10122

* Changelog: add #10101

* changelog: add #10105

* changelog: add #10190

* Changelog: add #10196

* changelog: add #10152

* Changelog: add #10153

* Testing list: add more details to Site Verification testing steps.

@see #10143 (comment)

* changelog: add #10194

* Changelog: add #10193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Search For all things related to Search [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants