Traffic Settings: add Jetpack Search upgrade message#27059
Conversation
- add an upgrade message for Jetpack Search - also for wp.com sites - reorder the traffic settings to put the stuff you may be more likely to toggle higher up
|
Top of traffic tab for Jetpack site:
Top of traffic tab for WP.com site:
|
|
I pushed a commit to address the prop warning. Besides that, the code looks OK to me. We should probably get a design review for the content in the banner since it seems like more than usual. |
ebinnion
left a comment
There was a problem hiding this comment.
I'll approve for now. But, I'd suggest waiting until we get the design review, or making changes after the design review.
eliorivero
left a comment
There was a problem hiding this comment.
Left a comment and also tagged for copy review.
|
|
||
| return ( | ||
| <div> | ||
| <div style={ { marginBottom: '16px' } }> |
There was a problem hiding this comment.
This should be moved to a stylesheet.
|
I'd tweak the headline: Add faster, more advanced searching to your site with Jetpack Professional In the body copy:
|
|
@ebinnion or @eliorivero can I get one last look. Only changes I made were to move the style into into the css sheet and some updates to the wording. @jeffgolenski fyi, @michelleweber helped a bit with some feedback on the wording and I'm going with that. The latest looks like:
I'll use the same wording in the Jetpack PR for an upgrade message. |
…-search-upgrade-msg
This adds an upgrade message in traffic settings where the Jetpack Search settings are displayed once a plan has been purchased.
The messaging is based on Automattic/jetpack#9747
I have also reordered the traffic settings page a bit to adjust which items are on top. Some thoughts behind this:
One question I have here is that I am seeing "Warning: Failed prop type: Invalid prop
descriptionsupplied toBanner." in my console (Chrome). I suspect this has to do with the gnarly html description I have used. Some way around this?