Skip to content

VideoPress: add plan support checks for all plans.#10122

Merged
zinigor merged 2 commits intomasterfrom
fix/videopress-plans
Sep 17, 2018
Merged

VideoPress: add plan support checks for all plans.#10122
zinigor merged 2 commits intomasterfrom
fix/videopress-plans

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Sep 10, 2018

Fixes #10085

Changes proposed in this Pull Request:

Make sure that all users of a Premium or Business plan, whether it's a one-year or 2-year plan, can use the VideoPress feature.

Testing instructions:

  1. Visit the wp-admin panel of an AT site with a one-year Business Plan
  2. Go to Jetpack > Settings
  3. Under Media > Video, you should be able to see a tab with the text Enable high-speed, ad-free video player to activate or deactivate VideoPress.
  4. Replace the site's Business Plan to a two-year one in Store Admin
  5. Go back to Jetpack > Settings
  6. Under Media, VideoPress seems to be unavailable, and the tab to turn it on or off is missing. Instead, there is a blue "Upgrade" button next to the text Host fast, high-quality, ad-free video.
  7. Install the Jetpack beta plugin
  8. Visit /wp-admin/admin.php?page=jetpack-beta and activate the fix/videopress-plans branch.
  9. Go back to Jetpack settings and make sure you can now activate the VideoPress feature.

Proposed changelog entry for your changes:

  • VideoPress: do not block access to the Video settings for 2-year plans.

@jeherve jeherve added Bug When a feature is broken and / or not performing as intended [Feature] VideoPress A feature to help you upload and insert videos on your site. [Status] In Progress [Pri] High labels Sep 10, 2018
@jeherve jeherve added this to the 6.6 milestone Sep 10, 2018
@jeherve jeherve self-assigned this Sep 10, 2018
@jeherve jeherve requested a review from a team as a code owner September 10, 2018 12:42
@jetpackbot
Copy link
Copy Markdown
Collaborator

That's a great PR description, thank you so much for your effort!

Generated by 🚫 dangerJS

public static $option_name = 'videopress';

/** @var array */
public static $jetpack_plans_with_videopress = array( 'jetpack_premium', 'jetpack_business' );
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that this wasn't used anymore, since a714b0b, so I removed it to avoid confusions.

@jeherve jeherve added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Sep 10, 2018
Copy link
Copy Markdown
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Sep 14, 2018
@zinigor zinigor merged commit 4ebedb8 into master Sep 17, 2018
@zinigor zinigor deleted the fix/videopress-plans branch September 17, 2018 16:40
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 17, 2018
jeherve added a commit that referenced this pull request Sep 24, 2018
jeherve added a commit that referenced this pull request Sep 25, 2018
* Readme: add boilerplate for next release, 6.6

* Add 6.5 to the changelog.txt file

* Set boilerplate testing list for 6.6

* Readme: update stable tag to 6.5

* Add bullets to 6.5 changelog items

* Readme: add link to previous changelogs

This will help folks who want to know more about past releases,
while keeping the readme.txt short so as to not overwhelm translators and site owners only looking for information about the last release.

* Changelog: add information at the top of the changelog file.

* Changelog: add #10054

* Changelog: add #10078

* Changelog: add #10079

* Changelog: add #10064

* Changelog: add #10094

* Changelog: add #10096

* Testing list: add more information based on #10087

* Changelog: add #9847

* Changelog: add #10084

* Changelog: add #9918

* Changelog: add #7614

* Changelog: add #10116

* Changelog: add #10108

* Changelog: add #10041

* Changelog: add #10121

* Changelog: add #10134

* Changelog: add #10130

* Changelog: add #10109

* changelog: add #10137

* changelog: add #9952

* changelog: add #10120

* changelog: add #10162

* Changelog: add #10163

* Changelog: add #10092

* changelog: add #10156

* Changelog: add #10154

* changelog: add #10122

* Changelog: add #10101

* changelog: add #10105

* changelog: add #10190

* Changelog: add #10196

* changelog: add #10152

* Changelog: add #10153

* Testing list: add more details to Site Verification testing steps.

@see #10143 (comment)

* changelog: add #10194

* Changelog: add #10193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] VideoPress A feature to help you upload and insert videos on your site. [Pri] High

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VideoPress: AT Sites on Two-Year Business Plan are asked to Upgrade to Activate VideoPress

5 participants