Infinite Scroll: Add privacy policy link by laghee · Pull Request #9918 · Automattic/jetpack

laghee · 2018-07-15T17:51:23Z

WP bundled themes now have a privacy policy link in their footer, which
is helpful for complying with GDPR rules, but users who enable the infinite
footer lose that link. This adds a similar link to the infinity footer $credits.

Changes proposed in this Pull Request:

Add a privacy policy link to $credits to mimic the new WP bundled theme link

Testing instructions:

Publish the privacy policy page on test site
Enable infinite scroll with this patch applied
Scroll down to display the infinite footer
Confirm that it now includes a link to the privacy policy page

(Edit: Added extra step for testing.)

brbrr · 2018-07-24T14:35:42Z

Hi @laghee. Thanks for your contribution!

I've tested your PR, but I wasn't able to see Privacy Policy link in IS footer:
(IS Enabled)

(IS Disabled)

Also, as you can see - there is redundant '/' just before "Proudly powered by WordPress" text. So I would expect that the_privacy_policy_link() return an empty string in my case.

brbrr · 2018-07-31T11:24:45Z

Moving it into next release

cc @laghee

laghee · 2018-07-31T15:30:13Z

Thanks, @brbrr ! You're right -- I can see this locally (now that I unbroke my MAMP setup).

I did some investigation, and it's not that the_privacy_policy_link() is returning an empty string, but rather, it's not inserting the link into the credits class, so the link is just floating around in the ether, in its privacy policy link class, above the infinite footer div ... 🤔 ... weird.

I'll poke around a little to see if I can figure out what's going wrong and try to push a fix in the next couple of days.

laghee · 2018-08-01T13:48:58Z

@brbrr I changed the retrieval method to use get_privacy_policy_url() instead of the_privacy_policy_link, and that appears to have fixed the problem. This works for me locally both with the privacy policy page enabled and not.

Using the_privacy_policy_link meant the link was coming back already formatted, so it wasn't being inserted into the blog-credits div. (It also made the link text inaccessible for easy translation.)

The Travis checks look like they have to do with a new build configuration and not anything I did, but let me know if I need to tweak something.

brbrr · 2018-08-03T15:35:15Z

Thanks for your contribution! Now I can see the Privacy Policy link.

brbrr

Functionality reviewed - LGTM 🚢

brbrr · 2018-08-06T13:35:29Z

modules/infinite-scroll/infinity.php

Missing space between '(' & 'Privacy Policy'

@brbrr Oops! I can push another commit right now. I assume I should amend the last one so it's not just a typo fix?

No worries about number of commits. We are squashing before merge. Thanks!

mdawaffe · 2018-08-14T22:33:08Z

Nice! I see that the default themes (twentyten, etc.) all use the_privacy_policy_link()/get_the_privacy_policy_link(), which uses the Privacy Policy's page title as the link text. Should we be using those functions instead so that we use that title as well?

jetpackbot · 2018-08-15T18:07:02Z

	Warnings
⚠️	"Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS

laghee · 2018-08-15T18:10:17Z

@mdawaffe You're right -- that worked like a charm! I should have realized that since the privacy page is just another blog page, the title could be customized like anything else. Displaying just "Privacy Policy" would be annoying to anyone who had bothered to write their own title.

Thanks for the help!

mdawaffe · 2018-08-23T21:30:24Z

Do we still need that <span role="separator" aria-hidden="true"> from before? I don't know :)

oskosk · 2018-08-28T21:45:15Z

modules/infinite-scroll/infinity.php

Should we check if get_privacy_policy_url() is defined (Only WP 4.9.6 and later define it ) ?

WP bundled themes now have a privacy policy link in their footer, which is helpful for complying with GDPR rules, but users who enable the infinite footer lose that link. This adds a similar link to the infinity footer $credits.

As `the_privacy_policy_link` displays a pre-formatted link, it was not being incorporated into the `blog-credits` div. The 'Privacy Policy' link text was also not easily accessible for translation. Using `get_privacy_policy_url()` allowed for the formatting to match the rest of the credits on the footer, and this secured the correct behavior.

…y_link() As `get_privacy_policy_url()` comes complete with the privacy policy page's title rather than set text, this is a better solution for displaying the link.

… span tag Since `get_privacy_policy_url` is not defined before WP 4.9.6, this adds a check to make the default infinite footer backward compatible.

laghee · 2018-08-31T20:04:28Z

I made changes requested by @oskosk & @mdawaffe. Sorry about the delay!

mdawaffe · 2018-09-04T21:57:50Z

Thanks for your persistence! Looks good to me.

We now check if the function exists before to use it.

- Use spaces inside parenthesis. - Use Yoda condition.

jeherve

I made a small change for coding standards, but other than that I think we are all set. Merging.

Thank you for your contribution!

@see

* Readme: add boilerplate for next release, 6.6 * Add 6.5 to the changelog.txt file * Set boilerplate testing list for 6.6 * Readme: update stable tag to 6.5 * Add bullets to 6.5 changelog items * Readme: add link to previous changelogs This will help folks who want to know more about past releases, while keeping the readme.txt short so as to not overwhelm translators and site owners only looking for information about the last release. * Changelog: add information at the top of the changelog file. * Changelog: add #10054 * Changelog: add #10078 * Changelog: add #10079 * Changelog: add #10064 * Changelog: add #10094 * Changelog: add #10096 * Testing list: add more information based on #10087 * Changelog: add #9847 * Changelog: add #10084 * Changelog: add #9918 * Changelog: add #7614 * Changelog: add #10116 * Changelog: add #10108 * Changelog: add #10041 * Changelog: add #10121 * Changelog: add #10134 * Changelog: add #10130 * Changelog: add #10109 * changelog: add #10137 * changelog: add #9952 * changelog: add #10120 * changelog: add #10162 * Changelog: add #10163 * Changelog: add #10092 * changelog: add #10156 * Changelog: add #10154 * changelog: add #10122 * Changelog: add #10101 * changelog: add #10105 * changelog: add #10190 * Changelog: add #10196 * changelog: add #10152 * Changelog: add #10153 * Testing list: add more details to Site Verification testing steps. @see #10143 (comment) * changelog: add #10194 * Changelog: add #10193

laghee requested a review from a team as a code owner July 15, 2018 17:51

abidhahmed added [Status] Needs Review This PR is ready for review. [Status] Needs Testing We need to add this change to the testing call for this month's release labels Jul 17, 2018

abidhahmed added this to the 6.4 milestone Jul 17, 2018

abidhahmed added [Feature] Infinite Scroll Good For Community labels Jul 17, 2018

brbrr removed the Good For Community label Jul 24, 2018

brbrr modified the milestones: 6.4, 6.5 Jul 31, 2018

laghee force-pushed the add/privacy-policy-infinite-footer branch from 09958a5 to 765eb5f Compare August 1, 2018 13:34

brbrr added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Aug 3, 2018

brbrr approved these changes Aug 3, 2018

View reviewed changes

brbrr reviewed Aug 6, 2018

View reviewed changes

brbrr added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Aug 7, 2018

mdawaffe added [Status] Needs Review This PR is ready for review. and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Aug 14, 2018

oskosk previously requested changes Aug 28, 2018

View reviewed changes

oskosk added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Aug 28, 2018

oskosk removed this from the 6.5 milestone Aug 30, 2018

laghee added 5 commits August 31, 2018 22:01

Infinite Scroll: Add privacy policy link

15aee03

WP bundled themes now have a privacy policy link in their footer, which is helpful for complying with GDPR rules, but users who enable the infinite footer lose that link. This adds a similar link to the infinity footer $credits.

Infinite Scroll: Fix linting typo in default_footer function

9c35d0f

Infinite Scroll: Change retrieval method to use get_the_privacy_polic…

290e06c

…y_link() As `get_privacy_policy_url()` comes complete with the privacy policy page's title rather than set text, this is a better solution for displaying the link.

Infinite Scroll: Check if get_privacy_policy_url is defined and add…

6ed51c9

… span tag Since `get_privacy_policy_url` is not defined before WP 4.9.6, this adds a check to make the default infinite footer backward compatible.

laghee force-pushed the add/privacy-policy-infinite-footer branch from bee286a to 6ed51c9 Compare August 31, 2018 20:02

mdawaffe approved these changes Sep 4, 2018

View reviewed changes

mdawaffe added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Sep 4, 2018

mdawaffe added this to the 6.6 milestone Sep 4, 2018

Infinite Scroll: coding standards for privacy link

19c25ef

- Use spaces inside parenthesis. - Use Yoda condition.

jeherve approved these changes Sep 7, 2018

View reviewed changes

jeherve merged commit 1b48b87 into Automattic:master Sep 7, 2018

matticbot added the [Status] Needs Changelog label Sep 7, 2018

jeherve added [Status] Has Changelog and removed [Status] Needs Review This PR is ready for review. [Status] Needs Changelog labels Sep 7, 2018

jeherve added a commit that referenced this pull request Sep 24, 2018

Changelog: add #9918

b4eef07

Conversation

laghee commented Jul 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this Pull Request:

Testing instructions:

Uh oh!

brbrr commented Jul 24, 2018

Uh oh!

brbrr commented Jul 31, 2018

Uh oh!

laghee commented Jul 31, 2018

Uh oh!

laghee commented Aug 1, 2018

Uh oh!

brbrr commented Aug 3, 2018

Uh oh!

brbrr left a comment

Choose a reason for hiding this comment

Uh oh!

brbrr Aug 6, 2018

Choose a reason for hiding this comment

Uh oh!

laghee Aug 6, 2018

Choose a reason for hiding this comment

Uh oh!

brbrr Aug 6, 2018

Choose a reason for hiding this comment

Uh oh!

mdawaffe commented Aug 14, 2018

Uh oh!

jetpackbot commented Aug 15, 2018

Uh oh!

laghee commented Aug 15, 2018

Uh oh!

mdawaffe commented Aug 23, 2018

Uh oh!

oskosk Aug 28, 2018

Choose a reason for hiding this comment

Uh oh!

laghee commented Aug 31, 2018

Uh oh!

mdawaffe commented Sep 4, 2018

Uh oh!

jeherve left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

laghee commented Jul 15, 2018 •

edited

Loading