Conversation
This PR fixes a PHP notice found in my error log>
In cases where get_user_by doesn't return a valid user object this PR supressed the followind php Notice.
[04-Sep-2018 20:23:06 UTC] PHP Notice: Trying to get property of non-object in /var/www/html/wp-content/plugins/jetpack/sync/class.jetpack-sync-module-users.php on line 299
[04-Sep-2018 20:23:06 UTC] PHP Stack trace:
[04-Sep-2018 20:23:06 UTC] PHP 1. {main}() /var/www/html/wp-admin/themes.php:0
[04-Sep-2018 20:23:06 UTC] PHP 2. switch_theme($stylesheet = *uninitialized*) /var/www/html/wp-admin/themes.php:33
[04-Sep-2018 20:23:06 UTC] PHP 3. do_action($tag = *uninitialized*, $arg = *uninitialized*, *uninitialized*, *uninitialized*) /var/www/html/wp-includes/theme.php:753
[04-Sep-2018 20:23:06 UTC] PHP 4. WP_Hook->do_action($args = *uninitialized*) /var/www/html/wp-includes/plugin.php:453
[04-Sep-2018 20:23:06 UTC] PHP 5. WP_Hook->apply_filters($value = *uninitialized*, $args = *uninitialized*) /var/www/html/wp-includes/class-wp-hook.php:310
[04-Sep-2018 20:23:06 UTC] PHP 6. TGM_Plugin_Activation->update_dismiss(*uninitialized*) /var/www/html/wp-includes/class-wp-hook.php:288
[04-Sep-2018 20:23:06 UTC] PHP 7. delete_metadata($meta_type = *uninitialized*, $object_id = *uninitialized*, $meta_key = *uninitialized*, $meta_value = *uninitialized*, $delete_all = *uninitialized*) /var/www/html/wp-content/themes/influencer/inc/tgmpa/class-tgm-plugin-activation.php:1910
[04-Sep-2018 20:23:06 UTC] PHP 8. do_action($tag = *uninitialized*, $arg = *uninitialized*, *uninitialized*, *uninitialized*, *uninitialized*) /var/www/html/wp-includes/meta.php:433
[04-Sep-2018 20:23:06 UTC] PHP 9. WP_Hook->do_action($args = *uninitialized*) /var/www/html/wp-includes/plugin.php:453
[04-Sep-2018 20:23:06 UTC] PHP 10. WP_Hook->apply_filters($value = *uninitialized*, $args = *uninitialized*) /var/www/html/wp-includes/class-wp-hook.php:310
[04-Sep-2018 20:23:06 UTC] PHP 11. Jetpack_Sync_Module_Users->maybe_save_user_meta($meta_id = *uninitialized*, $user_id = *uninitialized*, $meta_key = *uninitialized*, $value = *uninitialized*) /var/www/html/wp-includes/class-wp-hook.php:286
Contributor
|
Caution: This PR has changes that must be merged to WordPress.com |
Collaborator
|
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
jeherve
approved these changes
Sep 5, 2018
Member
jeherve
left a comment
There was a problem hiding this comment.
That makes sense. I can't reproduce the error right now, but I know that some role management plugins can sometimes mess things up like that from time.
LGTM!
jeherve
added a commit
that referenced
this pull request
Sep 25, 2018
* Readme: add boilerplate for next release, 6.6 * Add 6.5 to the changelog.txt file * Set boilerplate testing list for 6.6 * Readme: update stable tag to 6.5 * Add bullets to 6.5 changelog items * Readme: add link to previous changelogs This will help folks who want to know more about past releases, while keeping the readme.txt short so as to not overwhelm translators and site owners only looking for information about the last release. * Changelog: add information at the top of the changelog file. * Changelog: add #10054 * Changelog: add #10078 * Changelog: add #10079 * Changelog: add #10064 * Changelog: add #10094 * Changelog: add #10096 * Testing list: add more information based on #10087 * Changelog: add #9847 * Changelog: add #10084 * Changelog: add #9918 * Changelog: add #7614 * Changelog: add #10116 * Changelog: add #10108 * Changelog: add #10041 * Changelog: add #10121 * Changelog: add #10134 * Changelog: add #10130 * Changelog: add #10109 * changelog: add #10137 * changelog: add #9952 * changelog: add #10120 * changelog: add #10162 * Changelog: add #10163 * Changelog: add #10092 * changelog: add #10156 * Changelog: add #10154 * changelog: add #10122 * Changelog: add #10101 * changelog: add #10105 * changelog: add #10190 * Changelog: add #10196 * changelog: add #10152 * Changelog: add #10153 * Testing list: add more details to Site Verification testing steps. @see #10143 (comment) * changelog: add #10194 * Changelog: add #10193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a PHP notice found in my error log>
In cases where get_user_by doesn't return a valid user object this PR supressed the followind php Notice.
Testing instructions:
I am not sure how to reproduce the error :(
Changes proposed in this Pull Request:
Proposed changelog entry for your changes:
Removes a PHP Notice