Shortcodes: ensure that we generate RTL & min files for slideshows#10162
Merged
Shortcodes: ensure that we generate RTL & min files for slideshows#10162
Conversation
Up until now, no rtl files or min files were generated when running `yarn build`. This caused issues on RTL sites, but also in other places where we look for the file, like in the work we are doing in #10102
Collaborator
|
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
Contributor
|
Yarp, especially as it's flagged to swap to the rtl version. jetpack/modules/shortcodes/slideshow.php Line 282 in ce014ac My guess is that it's heretofore been relying on wpcom side of the sync to manage the changes over. Better that we do it ourselves, methinks. |
kraftbj
approved these changes
Sep 18, 2018
jeherve
added a commit
that referenced
this pull request
Sep 25, 2018
* Readme: add boilerplate for next release, 6.6 * Add 6.5 to the changelog.txt file * Set boilerplate testing list for 6.6 * Readme: update stable tag to 6.5 * Add bullets to 6.5 changelog items * Readme: add link to previous changelogs This will help folks who want to know more about past releases, while keeping the readme.txt short so as to not overwhelm translators and site owners only looking for information about the last release. * Changelog: add information at the top of the changelog file. * Changelog: add #10054 * Changelog: add #10078 * Changelog: add #10079 * Changelog: add #10064 * Changelog: add #10094 * Changelog: add #10096 * Testing list: add more information based on #10087 * Changelog: add #9847 * Changelog: add #10084 * Changelog: add #9918 * Changelog: add #7614 * Changelog: add #10116 * Changelog: add #10108 * Changelog: add #10041 * Changelog: add #10121 * Changelog: add #10134 * Changelog: add #10130 * Changelog: add #10109 * changelog: add #10137 * changelog: add #9952 * changelog: add #10120 * changelog: add #10162 * Changelog: add #10163 * Changelog: add #10092 * changelog: add #10156 * Changelog: add #10154 * changelog: add #10122 * Changelog: add #10101 * changelog: add #10105 * changelog: add #10190 * Changelog: add #10196 * changelog: add #10152 * Changelog: add #10153 * Testing list: add more details to Site Verification testing steps. @see #10143 (comment) * changelog: add #10194 * Changelog: add #10193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Up until now, no rtl files or min files were generated when running
yarn build.This caused issues on RTL sites, but also in other places where we look for the file,
like in the work we are doing in #10102
Testing instructions:
Apply this branch, run
yarn build, and check for 2 new minified files and an RTL file undermodules/shortcodes/css/.You can also check that the slideshows look good on a site using an RTL language.
Proposed changelog entry for your changes:
Shortcodes: ensure we build minified and RTL stylesheets for slideshows.