Jetpack: Add url request was made on/from to actor#10134
Conversation
This is automated check which relies on Generated by 🚫 dangerJS |
|
|
||
| function get_request_url() { | ||
| return 'http' . (isset($_SERVER['HTTPS']) ? 's' : '') . '://' . "{$_SERVER['HTTP_HOST']}{$_SERVER['REQUEST_URI']}"; | ||
| } |
There was a problem hiding this comment.
rather relying on $_SERVER here, which can be unreliable, I recommend using, the approach outlined here:
roccotripaldi
left a comment
There was a problem hiding this comment.
This has worked well on the few server configs i've tested on - Jetpack sandbox and docker with ngrok.
Confirmed there is a Talked with @gititon in Slack, who says this is fine for now. |
* Readme: add boilerplate for next release, 6.6 * Add 6.5 to the changelog.txt file * Set boilerplate testing list for 6.6 * Readme: update stable tag to 6.5 * Add bullets to 6.5 changelog items * Readme: add link to previous changelogs This will help folks who want to know more about past releases, while keeping the readme.txt short so as to not overwhelm translators and site owners only looking for information about the last release. * Changelog: add information at the top of the changelog file. * Changelog: add #10054 * Changelog: add #10078 * Changelog: add #10079 * Changelog: add #10064 * Changelog: add #10094 * Changelog: add #10096 * Testing list: add more information based on #10087 * Changelog: add #9847 * Changelog: add #10084 * Changelog: add #9918 * Changelog: add #7614 * Changelog: add #10116 * Changelog: add #10108 * Changelog: add #10041 * Changelog: add #10121 * Changelog: add #10134 * Changelog: add #10130 * Changelog: add #10109 * changelog: add #10137 * changelog: add #9952 * changelog: add #10120 * changelog: add #10162 * Changelog: add #10163 * Changelog: add #10092 * changelog: add #10156 * Changelog: add #10154 * changelog: add #10122 * Changelog: add #10101 * changelog: add #10105 * changelog: add #10190 * Changelog: add #10196 * changelog: add #10152 * Changelog: add #10153 * Testing list: add more details to Site Verification testing steps. @see #10143 (comment) * changelog: add #10194 * Changelog: add #10193
This PR adds the url the request was made on/from to the sync actor to assist in troubleshooting issues where the actor and or payload data does not seem correct.
Testing instructions:
Please see the detailed instructions I've added for how to observe Jetpack Sync data that is sent from Jetpack to a WPCOM sandbox: PCYsg-hnH-p2
Please follow the above instructions, make a post on your Jetpack site, and confirm that the sync payload (array) that appears in your terminal has a
from_urlfield.