Skip to content

Fix - No GA code when Enable Enhanced eCommerce option is active but WooCommerce is not active#10092

Merged
jeherve merged 2 commits intomasterfrom
fix/no-ga-code-when-woo-inactive
Sep 19, 2018
Merged

Fix - No GA code when Enable Enhanced eCommerce option is active but WooCommerce is not active#10092
jeherve merged 2 commits intomasterfrom
fix/no-ga-code-when-woo-inactive

Conversation

@htdat
Copy link
Copy Markdown
Member

@htdat htdat commented Sep 3, 2018

👋from a HE. My first PR. Thanks for the feedback in advance :)

Fixes #10091

Changes proposed in this Pull Request:

Currently, Jetpack does not output the GA tracking code in a specific case, which can be replicated as you see on #10091 :

  • Enable Enhanced eCommerce option is active
  • But WooCommerce is not active

Testing instructions:

  1. Activate WooCommerce on a Premium or Pro site.
  2. In https://wordpress.com/settings/traffic/my-site.com, activate Enable Enhanced eCommerce.
  3. Deactivate WooCommerce
  4. Visit the site without login as an admin.
  5. Check the HTML output and find the GA code by searching Jetpack Google Analytics.

Proposed changelog entry for your changes:

Fix Bug - Do not output the Google Analytics code when Enable Enhanced eCommerce option is active but WooCommerce is not active

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Google Analytics [Pri] Normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants