Lazy Images: Fix conflict with photon after switching to use srcset#10087
Merged
Lazy Images: Fix conflict with photon after switching to use srcset#10087
Conversation
Collaborator
|
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
5da9bf5 to
a4a294a
Compare
a4a294a to
d9a7664
Compare
oskosk
approved these changes
Sep 6, 2018
Contributor
oskosk
left a comment
There was a problem hiding this comment.
Tests great. Confirmed that fixes the issue 
jeherve
added a commit
that referenced
this pull request
Sep 24, 2018
jeherve
added a commit
that referenced
this pull request
Sep 25, 2018
* Readme: add boilerplate for next release, 6.6 * Add 6.5 to the changelog.txt file * Set boilerplate testing list for 6.6 * Readme: update stable tag to 6.5 * Add bullets to 6.5 changelog items * Readme: add link to previous changelogs This will help folks who want to know more about past releases, while keeping the readme.txt short so as to not overwhelm translators and site owners only looking for information about the last release. * Changelog: add information at the top of the changelog file. * Changelog: add #10054 * Changelog: add #10078 * Changelog: add #10079 * Changelog: add #10064 * Changelog: add #10094 * Changelog: add #10096 * Testing list: add more information based on #10087 * Changelog: add #9847 * Changelog: add #10084 * Changelog: add #9918 * Changelog: add #7614 * Changelog: add #10116 * Changelog: add #10108 * Changelog: add #10041 * Changelog: add #10121 * Changelog: add #10134 * Changelog: add #10130 * Changelog: add #10109 * changelog: add #10137 * changelog: add #9952 * changelog: add #10120 * changelog: add #10162 * Changelog: add #10163 * Changelog: add #10092 * changelog: add #10156 * Changelog: add #10154 * changelog: add #10122 * Changelog: add #10101 * changelog: add #10105 * changelog: add #10190 * Changelog: add #10196 * changelog: add #10152 * Changelog: add #10153 * Testing list: add more details to Site Verification testing steps. @see #10143 (comment) * changelog: add #10194 * Changelog: add #10193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some JavaScript that sets height and width for Photon images had some checks for
data-lazy-srcthat would postpone adding those height and width details. Here's an example:jetpack/modules/photon/photon.js
Line 15 in dc3e81b
After switching to use srcset instead of src for lazy loading, and removing
data-lazy-src, the height and width attributes were being set prematurely, while the image was still 1x1. 😞Changes proposed in this Pull Request:
Add
data-lazy-srcback so that the photon image size checks are postponed until the image is actually loaded.Ideally, we should probably make changes directly to the
photon.jsanddevicepx.jsfiles. But, I'd rather postpone that until we verify thatsrcsetwill work in the wild as expected.Testing instructions:
On a connected site:
Proposed changelog entry for your changes:
None