Gutenberg: add view files to Gutenberg tester#10154
Conversation
+ support for RTL
This is automated check which relies on Generated by 🚫 dangerJS |
|
|
brbrr
left a comment
There was a problem hiding this comment.
Tested with JN gutenpack (https://jurassic.ninja/create/?shortlived&gutenberg&gutenpack&jetpack-beta&branch=update/gutenberg-tester-add-view-file&calypsobranch=try/stylish-hello-dolly)
Functionally works well, no errors shown. _inc/blocks/jetpack-editor.rtl.css RTL styles loaded for RTL language.
tyxla
left a comment
There was a problem hiding this comment.
Tests well for me, and code looks great 👍 Great work! 💯
| $version | ||
| ); | ||
| wp_register_style( 'jetpack-blocks-editor', $editor_style, array(), $version ); | ||
| wp_register_script( 'jetpack-blocks-view', $view_script, array(), $version ); |
There was a problem hiding this comment.
We eventually might want to audit the dependencies here, as some of the blocks might end up needing specific WordPress packages or another script.
* Readme: add boilerplate for next release, 6.6 * Add 6.5 to the changelog.txt file * Set boilerplate testing list for 6.6 * Readme: update stable tag to 6.5 * Add bullets to 6.5 changelog items * Readme: add link to previous changelogs This will help folks who want to know more about past releases, while keeping the readme.txt short so as to not overwhelm translators and site owners only looking for information about the last release. * Changelog: add information at the top of the changelog file. * Changelog: add #10054 * Changelog: add #10078 * Changelog: add #10079 * Changelog: add #10064 * Changelog: add #10094 * Changelog: add #10096 * Testing list: add more information based on #10087 * Changelog: add #9847 * Changelog: add #10084 * Changelog: add #9918 * Changelog: add #7614 * Changelog: add #10116 * Changelog: add #10108 * Changelog: add #10041 * Changelog: add #10121 * Changelog: add #10134 * Changelog: add #10130 * Changelog: add #10109 * changelog: add #10137 * changelog: add #9952 * changelog: add #10120 * changelog: add #10162 * Changelog: add #10163 * Changelog: add #10092 * changelog: add #10156 * Changelog: add #10154 * changelog: add #10122 * Changelog: add #10101 * changelog: add #10105 * changelog: add #10190 * Changelog: add #10196 * changelog: add #10152 * Changelog: add #10153 * Testing list: add more details to Site Verification testing steps. @see #10143 (comment) * changelog: add #10194 * Changelog: add #10193
viewfiles to Gutenberg testerjetpack-editor.*toeditor.*Testing instructions:
Switch to
try/stylish-hello-dollybranch in Calypso (Gutenberg: add styles to Hello Dolly wp-calypso#27241)From calypso folder, generate files — note to change
output-dirto correct place:Add these filters to your Jetpack setup, e.g. to a file in
mu-pluginsfolder:These will: enable loading these Gutenberg assets from the CDN. You should see all the files throw 404. We'll still need tofollow up and add these files.
To disable loading via CDN and load files from your local disk instead, add:
You should now see all the files load and "Hello Dolly" Gutenberg block be available:

If you switch your site to RTL mode (
e.g. with rtl-testere.g. by changing your language from settings to Hebrew. RTL tester doesn't seem to triggeris_rtl()), you should see at both theme, and the editor side RTL CSS files loaded instead.