Widgets: concatenate author and Social Icons widget CSS#10280
Merged
Widgets: concatenate author and Social Icons widget CSS#10280
Conversation
Follow up for #10153 The files were not enqueued anymore as of the PR above, but the CSS did not get added to the jetpack.css file that is enqueued instead of the singular files.
Collaborator
|
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
Contributor
|
To add to the testing instructions, do not test on Twenty Seventeen as that theme's normal styles will hide the issue being addressed. Try another theme, like Twenty Fifteen. |
kraftbj
approved these changes
Oct 9, 2018
Contributor
kraftbj
left a comment
There was a problem hiding this comment.
Noting specifically testing with Twenty Seventeen would not duplicate the bug (and how this got through review initially), so tested with Twenty Fifteen per original customer report.
dereksmart
approved these changes
Oct 9, 2018
Contributor
dereksmart
left a comment
There was a problem hiding this comment.
Looks good! CSS is added on fresh build
jeherve
added a commit
that referenced
this pull request
Oct 9, 2018
* Widgets: concatenate author and Social Icons widget CSS Follow up for #10153 The files were not enqueued anymore as of the PR above, but the CSS did not get added to the jetpack.css file that is enqueued instead of the singular files. * CSS builder: remove authors file since it was already in the list * CSS Concatenation: add comments to avoid issues in the future.
Member
Author
|
Cherry-picked to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Follow up for #10153
The files were not enqueued anymore as of the PR above, but the CSS
did not get added to the jetpack.css file that is enqueued instead of the singular files.
Testing instructions:
gulp frontendcsscss/jetpack.csswas updated and includes the necessary CSS.WP_DEBUGis set tofalse.Proposed changelog entry for your changes: