[code-example-syntax] hippo-proof code examples#5364
Merged
sarah11918 merged 3 commits intomainfrom Nov 13, 2023
Merged
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hippotastic
approved these changes
Nov 13, 2023
Contributor
hippotastic
left a comment
There was a problem hiding this comment.
LGTM, too! I see that you've even added titles to code blocks that were missing them before, so win-win! Great!
yanthomasdev
added a commit
that referenced
this pull request
Nov 16, 2023
* i18n(fr) Fix multiple file with PR #5364 * Update astro-pages.mdx * Update astro-syntax.mdx * Update routing.mdx Addition of some missing parts * Update routing.mdx Fix L431 * Update sharing-state.mdx * Update imports.mdx Fix L220 * Update imports.mdx Fix L224 * Update 3.mdx Del blank L35 * Update routing.mdx fix recipes link * Update imports.mdx Fix link L220 * Update src/content/docs/fr/guides/imports.mdx Merci Co-authored-by: Thomas Bnt <thomasbnt@protonmail.com> * Update src/content/docs/fr/guides/imports.mdx Co-authored-by: Thomas Bnt <thomasbnt@protonmail.com> --------- Co-authored-by: Thomas Bnt <thomasbnt@protonmail.com> Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
fhiromasa
added a commit
to fhiromasa/astro-docs
that referenced
this pull request
Mar 3, 2024
[code-example-syntax] hippo-proof code examples (withastro#5364)
yanthomasdev
added a commit
that referenced
this pull request
Mar 5, 2024
* Update routing.mdx in ja Modified to be similar to the English sample code in "Nested Pagination" section * update routing.mdx in ja [code-example-syntax] hippo-proof code examples (#5364) * update routing.mdx in ja fix: add spacing to 'added in' texts (#5765) * update routing.mdx in ja Add <ReadMore> component (#6267) * Update routing.mdx in ja Document new routing priority behavior (#6386) * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> --------- Co-authored-by: Shinya Fujino <shf0811@gmail.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
trueberryless
added a commit
to trueberryless/withastro-docs
that referenced
this pull request
Oct 22, 2024
trueberryless
added a commit
to trueberryless/withastro-docs
that referenced
this pull request
Oct 30, 2024
yanthomasdev
added a commit
that referenced
this pull request
Nov 4, 2024
* update translation #1442 * update translation #1434 * update translation #1510 * update translation #1538 * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * update translation #1638 * update translation #2091 * update translation #2133 * update translation #2409 * update translation #2371 * update translation #4610 * update translation #5128 * update translation #5205 * update translation #5240 * update translation #5364 * update translation #5765 * update translation #6267 * remove paragraph where I cant find when it was deleted in original version * update translation #6620 * update translation #8495 * update translation #8573 * update translation #9336 * update translation #9336 2/2 didnt save file locally, so git didnt add * fix all visual differences by comparing manually against original english version * fix broken links in `astro-pages.mdx` * Breaking changes to other files! fixing links which link to the �stro-pages.mdx file * but now... * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> * revert Update markdown-content.mdx @lunaria-track:src/content/docs/de/basics/astro-pages.mdx --------- Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Some changes to code snippet syntax (mostly titles) in preparation for Hippo's proposed changes to Expressive Code.
Ideally, we'd replace every code snippet in docs with the
title=""syntax, but this is the minimum viable change for now to let @hippotastic make his changes.Related issues & labels (optional)