Document new routing priority behavior#6386
Merged
sarah11918 merged 7 commits intowithastro:mainfrom Jan 18, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
VoxelMC
reviewed
Jan 14, 2024
Contributor
VoxelMC
left a comment
There was a problem hiding this comment.
Nice work Fryuni! Thank you for documenting all of these rules!
I have left some typo fixes and suggestions for the routing.mdx file, but not the reference files because I believe those are auto-generated from the JSDocs.
Hope they help!
Member
|
I am noting that this feature will be released as an experimental flag for 4.2.0, which means that the ONLY documentation should be in the changeset and This PR should not be merged as there will be no wider docs changes (as there never are for experimental flag features changing behaviour. All documentation is contained to the experimental config section). BUT, we can use this to help craft that! We will use withastro/astro#9644 as a model/reference for how to document for an experimental flag that builds on/changes existing features. |
sarah11918
previously requested changes
Jan 15, 2024
Member
sarah11918
left a comment
There was a problem hiding this comment.
This is not to be merged, used in helping us prepare documentation in withastro/astro#9439 only.
Co-authored-by: voxel!() <voxelmc@hotmail.com>
sarah11918
approved these changes
Jan 16, 2024
Member
sarah11918
left a comment
There was a problem hiding this comment.
Last piece of the puzzle! Approved!
Member
Author
|
Lovely, thanks for sending the changes @sarah11918. You're the best! |
yanthomasdev
added a commit
that referenced
this pull request
Jan 25, 2024
* Update with PR #6440 * Update with PR #6386 * Up with PR #6532 * Up with PR #6436 * Upd Just for Lunaria with PR #6444 * Up with PR #6402 * Up with PR #6548 * Up with PR #6430 * Up with PR #6469 * Up with PR #6522 * Up with PR #6272 * Update src/content/docs/fr/editor-setup.mdx Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com> * Update src/content/docs/fr/reference/publish-to-npm.mdx Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com> --------- Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
ematipico
pushed a commit
that referenced
this pull request
Jan 26, 2024
Co-authored-by: voxel!() <voxelmc@hotmail.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
ematipico
pushed a commit
that referenced
this pull request
Jan 26, 2024
* Update with PR #6440 * Update with PR #6386 * Up with PR #6532 * Up with PR #6436 * Upd Just for Lunaria with PR #6444 * Up with PR #6402 * Up with PR #6548 * Up with PR #6430 * Up with PR #6469 * Up with PR #6522 * Up with PR #6272 * Update src/content/docs/fr/editor-setup.mdx Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com> * Update src/content/docs/fr/reference/publish-to-npm.mdx Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com> --------- Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
fhiromasa
added a commit
to fhiromasa/astro-docs
that referenced
this pull request
Mar 3, 2024
Document new routing priority behavior (withastro#6386)
yanthomasdev
added a commit
that referenced
this pull request
Mar 5, 2024
* Update routing.mdx in ja Modified to be similar to the English sample code in "Nested Pagination" section * update routing.mdx in ja [code-example-syntax] hippo-proof code examples (#5364) * update routing.mdx in ja fix: add spacing to 'added in' texts (#5765) * update routing.mdx in ja Add <ReadMore> component (#6267) * Update routing.mdx in ja Document new routing priority behavior (#6386) * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> --------- Co-authored-by: Shinya Fujino <shf0811@gmail.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description