fix: add spacing to 'added in' texts by kevinzunigacuellar · Pull Request #5765 · withastro/docs

kevinzunigacuellar · 2023-12-13T03:50:59Z

Description

Add spacing to <Since /> elements

Before	After

vercel · 2023-12-13T03:51:05Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	Dec 13, 2023 6:14pm

ElianCodes · 2023-12-13T08:38:11Z

Wouldn't it make more sense to add padding to the <Since /> component instead of wrapping all of them in a <p />?

kevinzunigacuellar · 2023-12-13T14:33:14Z

Wouldn't it make more sense to add padding to the <Since /> component instead of wrapping all of them in a <p />?

It would but there are some instances of Since that are inlined 😅

ElianCodes · 2023-12-13T14:43:14Z

in that case, what about a prop for spacing, that defaults to none?

delucis

LGTM! Thanks for tackling this @kevinzunigacuellar 💜

sarah11918 · 2023-12-13T18:09:10Z

Thanks, Kevin! I updated Astro Docs Docs to show this usage of the component in a standalone line!

Update french translation for rss.mdx file with PR #5765 Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>

…mdx` (#6363) * i18n(fr) Update reading-time.mdx Just for translator tracker because the PR #5766 should have been [ignore] * Update astro-pages.mdx * Update framework-components.mdx * Update layouts.mdx * Update routing.mdx * Update editor-setup.mdx * Update configuring-astro.mdx * Update cloudflare.mdx * Update deno.mdx * Update netlify.mdx * Update vercel.mdx * Update imports.mdx * Update auto.mdx * Update manual.mdx * Update cli-reference.mdx Update and del some parts * Update cli-reference.mdx Update fiule with PR #5512 #5651 #5604 #5765 #6040 #6043 #6109 #6267 * Update auto.mdx * Update cloudflare.mdx fix PR #5284 * Update markdown-content.mdx * Update auto.mdx * Update src/content/docs/fr/core-concepts/astro-pages.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Update src/content/docs/fr/core-concepts/astro-pages.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Update src/content/docs/fr/core-concepts/astro-pages.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Update src/content/docs/fr/core-concepts/framework-components.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Update src/content/docs/fr/core-concepts/framework-components.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Update src/content/docs/fr/guides/markdown-content.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Update src/content/docs/fr/install/manual.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Update src/content/docs/fr/install/manual.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Update src/content/docs/fr/reference/cli-reference.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Apply suggestions from code review --------- Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> Co-authored-by: Elian <15145918+ElianCodes@users.noreply.github.com>

Update french translation for rss.mdx file with PR #5765 Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>

…mdx` (#6363) * i18n(fr) Update reading-time.mdx Just for translator tracker because the PR #5766 should have been [ignore] * Update astro-pages.mdx * Update framework-components.mdx * Update layouts.mdx * Update routing.mdx * Update editor-setup.mdx * Update configuring-astro.mdx * Update cloudflare.mdx * Update deno.mdx * Update netlify.mdx * Update vercel.mdx * Update imports.mdx * Update auto.mdx * Update manual.mdx * Update cli-reference.mdx Update and del some parts * Update cli-reference.mdx Update fiule with PR #5512 #5651 #5604 #5765 #6040 #6043 #6109 #6267 * Update auto.mdx * Update cloudflare.mdx fix PR #5284 * Update markdown-content.mdx * Update auto.mdx * Update src/content/docs/fr/core-concepts/astro-pages.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Update src/content/docs/fr/core-concepts/astro-pages.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Update src/content/docs/fr/core-concepts/astro-pages.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Update src/content/docs/fr/core-concepts/framework-components.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Update src/content/docs/fr/core-concepts/framework-components.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Update src/content/docs/fr/guides/markdown-content.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Update src/content/docs/fr/install/manual.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Update src/content/docs/fr/install/manual.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Update src/content/docs/fr/reference/cli-reference.mdx Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> * Apply suggestions from code review --------- Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

fix: add spacing to 'added in' texts (withastro#5765)

* Update routing.mdx in ja Modified to be similar to the English sample code in "Nested Pagination" section * update routing.mdx in ja [code-example-syntax] hippo-proof code examples (#5364) * update routing.mdx in ja fix: add spacing to 'added in' texts (#5765) * update routing.mdx in ja Add <ReadMore> component (#6267) * Update routing.mdx in ja Document new routing priority behavior (#6386) * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> --------- Co-authored-by: Shinya Fujino <shf0811@gmail.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>

* update translation #1442 * update translation #1434 * update translation #1510 * update translation #1538 * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * update translation #1638 * update translation #2091 * update translation #2133 * update translation #2409 * update translation #2371 * update translation #4610 * update translation #5128 * update translation #5205 * update translation #5240 * update translation #5364 * update translation #5765 * update translation #6267 * remove paragraph where I cant find when it was deleted in original version * update translation #6620 * update translation #8495 * update translation #8573 * update translation #9336 * update translation #9336 2/2 didnt save file locally, so git didnt add * fix all visual differences by comparing manually against original english version * fix broken links in `astro-pages.mdx` * Breaking changes to other files! fixing links which link to the �stro-pages.mdx file * but now... * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> * revert Update markdown-content.mdx @lunaria-track:src/content/docs/de/basics/astro-pages.mdx --------- Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>

add a few <p/>'s

9c6ef1b

vercel bot deployed to Preview December 13, 2023 03:51 View deployment

ElianCodes self-requested a review December 13, 2023 08:53

delucis approved these changes Dec 13, 2023

View reviewed changes

Merge branch 'main' into add-p

5cca98b

sarah11918 added site improvement Some thing that improves the website functionality - ask @delucis for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Dec 13, 2023

vercel bot deployed to Preview December 13, 2023 17:59 View deployment

Merge branch 'main' into add-p

0315c9e

vercel bot deployed to Preview December 13, 2023 18:14 View deployment

delucis merged commit 2d7a9d2 into main Dec 13, 2023

delucis deleted the add-p branch December 13, 2023 18:14

This was referenced Dec 20, 2023

i18n(zh-cn): add spacing to 'added in' texts #5850

Merged

i18n(zh-cn): Update images.mdx #5851

Merged

i18n(zh-cn): Update cli-reference.mdx #5869

Merged

morinokami mentioned this pull request Dec 24, 2023

I18n(ja) update images.mdx #5840

Merged

This was referenced Dec 24, 2023

i18n(ko-KR): update astro-pages.mdx #5912

Merged

i18n(ko-KR): update typescript.mdx #5924

Merged

This was referenced Jan 2, 2024

i18n(fr) Update astro-pages.mdx #6045

Merged

i18n(fr) Update routing.mdx #6049

Merged

i18n(fr) Update content-collections.mdx #6057

Merged

i18n(fr) Update rss.mdx #6096

Merged

i18n(fr) Update and create error file #6123

Merged

yanthomasdev added a commit that referenced this pull request Jan 4, 2024

i18n(fr) Update rss.mdx (#6096)

f77ae0f

Update french translation for rss.mdx file with PR #5765 Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>

liruifengv mentioned this pull request Jan 8, 2024

Fix formatting of version tags in API reference #6197

Merged

McFlyPartages mentioned this pull request Jan 13, 2024

i18n(fr) Big Update for typescript.mdx #6372

Merged

ematipico pushed a commit that referenced this pull request Jan 26, 2024

i18n(fr) Update rss.mdx (#6096)

1a408bd

Update french translation for rss.mdx file with PR #5765 Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>

morinokami mentioned this pull request Feb 24, 2024

i18n(ja): Update styling.mdx #7018

Merged

morinokami mentioned this pull request Mar 3, 2024

i18n(ja): Update routing.mdx in ja #7101

Merged

fhiromasa added a commit to fhiromasa/astro-docs that referenced this pull request Mar 3, 2024

update routing.mdx in ja

0e36aea

fix: add spacing to 'added in' texts (withastro#5765)

trueberryless added a commit to trueberryless/withastro-docs that referenced this pull request Oct 22, 2024

update translation withastro#5765

1144db6

trueberryless mentioned this pull request Oct 22, 2024

i18n(de): update basics/astro-pages.mdx #9759

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: add spacing to 'added in' texts#5765

fix: add spacing to 'added in' texts#5765
delucis merged 3 commits intomainfrom
add-p

kevinzunigacuellar commented Dec 13, 2023

Uh oh!

vercel bot commented Dec 13, 2023 •

edited

Loading

Uh oh!

ElianCodes commented Dec 13, 2023 •

edited

Loading

Uh oh!

kevinzunigacuellar commented Dec 13, 2023

Uh oh!

ElianCodes commented Dec 13, 2023

Uh oh!

delucis left a comment

Uh oh!

sarah11918 commented Dec 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

kevinzunigacuellar commented Dec 13, 2023

Description

Uh oh!

vercel bot commented Dec 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ElianCodes commented Dec 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kevinzunigacuellar commented Dec 13, 2023

Uh oh!

ElianCodes commented Dec 13, 2023

Uh oh!

delucis left a comment

Choose a reason for hiding this comment

Uh oh!

sarah11918 commented Dec 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vercel bot commented Dec 13, 2023 •

edited

Loading

ElianCodes commented Dec 13, 2023 •

edited

Loading