Document HTML Components and Clarify Page Types#1538
Merged
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sarah11918
reviewed
Sep 13, 2022
Member
sarah11918
left a comment
There was a problem hiding this comment.
Thanks @Jutanium! I love this additional content and have THOUGHTS for your consideration below. 😄
delucis
reviewed
Sep 13, 2022
Member
delucis
left a comment
There was a problem hiding this comment.
Yay! Glad we’re finally documenting this. I think you’ve done a great job scoping out where to place this too. Couple of nits and questions but otherwise looks really helpful 🙌
sarah11918
reviewed
Sep 13, 2022
sarah11918
reviewed
Sep 13, 2022
sarah11918
reviewed
Sep 13, 2022
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Member
|
I still want to delete "Leveraging Page Layouts" heading too. I don't think we need it, and I think it clutters the sidebar. Did you intentionally leave it in? Might also turn that Should Markdown Pages now be Markdown/MDX pages? |
sarah11918
reviewed
Sep 13, 2022
added 2 commits
September 13, 2022 13:23
This reverts commit a7d82e2.
sarah11918
reviewed
Sep 13, 2022
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
reviewed
Sep 13, 2022
sarah11918
reviewed
Sep 13, 2022
sarah11918
reviewed
Sep 13, 2022
sarah11918
reviewed
Sep 13, 2022
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
reviewed
Sep 13, 2022
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Member
|
LGTM DAN |
trueberryless
added a commit
to trueberryless/withastro-docs
that referenced
this pull request
Oct 21, 2024
yanthomasdev
added a commit
that referenced
this pull request
Nov 4, 2024
* update translation #1442 * update translation #1434 * update translation #1510 * update translation #1538 * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * update translation #1638 * update translation #2091 * update translation #2133 * update translation #2409 * update translation #2371 * update translation #4610 * update translation #5128 * update translation #5205 * update translation #5240 * update translation #5364 * update translation #5765 * update translation #6267 * remove paragraph where I cant find when it was deleted in original version * update translation #6620 * update translation #8495 * update translation #8573 * update translation #9336 * update translation #9336 2/2 didnt save file locally, so git didnt add * fix all visual differences by comparing manually against original english version * fix broken links in `astro-pages.mdx` * Breaking changes to other files! fixing links which link to the �stro-pages.mdx file * but now... * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> * revert Update markdown-content.mdx @lunaria-track:src/content/docs/de/basics/astro-pages.mdx --------- Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
Astro Componentsfor HTML ComponentsPagesto explain that there are different page types (thanks @delucis!)Astro Pagessection inPages, movingPage HTMLandLeveraging Page Layoutsunder that. These subsections don't describe all pages, just.astropages, so it doesn't make sense for them to be subsections of the overview.