content collections in styling, markdown pages#2409
Merged
sarah11918 merged 7 commits intomainfrom Jan 19, 2023
Merged
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sarah11918
commented
Jan 18, 2023
sarah11918
commented
Jan 18, 2023
delucis
reviewed
Jan 19, 2023
Member
delucis
left a comment
There was a problem hiding this comment.
Thanks for going through and doing this @sarah11918! Hopefully these comments show up ok and if they don't... I'll blame it on my phone.
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
delucis
approved these changes
Jan 19, 2023
Member
delucis
left a comment
There was a problem hiding this comment.
Thanks, Sarah! Let's get those sprinkles 💖
trueberryless
added a commit
to trueberryless/withastro-docs
that referenced
this pull request
Oct 22, 2024
yanthomasdev
added a commit
that referenced
this pull request
Nov 4, 2024
* update translation #1442 * update translation #1434 * update translation #1510 * update translation #1538 * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * update translation #1638 * update translation #2091 * update translation #2133 * update translation #2409 * update translation #2371 * update translation #4610 * update translation #5128 * update translation #5205 * update translation #5240 * update translation #5364 * update translation #5765 * update translation #6267 * remove paragraph where I cant find when it was deleted in original version * update translation #6620 * update translation #8495 * update translation #8573 * update translation #9336 * update translation #9336 2/2 didnt save file locally, so git didnt add * fix all visual differences by comparing manually against original english version * fix broken links in `astro-pages.mdx` * Breaking changes to other files! fixing links which link to the �stro-pages.mdx file * but now... * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> * revert Update markdown-content.mdx @lunaria-track:src/content/docs/de/basics/astro-pages.mdx --------- Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR starts to sprinkle in content collections in appropriate places throughout the docs.
Markdown/MDX: Content collections is now the recommended suggestion for creating pages, so it is now listed under the
## Markdown and MDX Pagesheading.Pages: Content collections is now mentioned in Pages
Styling of content collections came up in discussion, which is really no different than styling your Markdown content anywhere it occurs. So, in order to support new collections users this PR adds a section on Markdown styling to the Styling page. And, the Markdown/MDX page links TO it, rather than duplicating content.
TODO: Link to this new styling markdown section FROM the content collections page itself. This page already has a complicated PR in the works, so this will be added later to this PR or in a future one.