Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Vite’s `logLevel` option only adds more info in a local terminal
Member
|
What an amazing job @delucis 🚀 💪 🙌 Admittedly, I haven't clicked through every single page, but I tested a number of our more "interesting" pages, and I haven't yet found anything that looks off! Lots of time for people to click around and verify, and no problem to fix smaller things after the fact. So, I can't see any reason not to approve this! New year, new Docs tech! 🥳 |
sarah11918
approved these changes
Dec 28, 2022
Member
sarah11918
left a comment
There was a problem hiding this comment.
End of an Astro-Flavored Markdown era!
yanthomasdev
approved these changes
Dec 28, 2022
Member
yanthomasdev
left a comment
There was a problem hiding this comment.
Great job @delucis! 🙌
Looked through almost all pages and checked some less noticeable use of components (dev mode only warning aside, version, etc) and everything LGTM!
trueberryless
added a commit
to trueberryless/withastro-docs
that referenced
this pull request
Oct 22, 2024
yanthomasdev
added a commit
that referenced
this pull request
Nov 4, 2024
* update translation #1442 * update translation #1434 * update translation #1510 * update translation #1538 * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * update translation #1638 * update translation #2091 * update translation #2133 * update translation #2409 * update translation #2371 * update translation #4610 * update translation #5128 * update translation #5205 * update translation #5240 * update translation #5364 * update translation #5765 * update translation #6267 * remove paragraph where I cant find when it was deleted in original version * update translation #6620 * update translation #8495 * update translation #8573 * update translation #9336 * update translation #9336 2/2 didnt save file locally, so git didnt add * fix all visual differences by comparing manually against original english version * fix broken links in `astro-pages.mdx` * Breaking changes to other files! fixing links which link to the �stro-pages.mdx file * but now... * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> * revert Update markdown-content.mdx @lunaria-track:src/content/docs/de/basics/astro-pages.mdx --------- Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jump to deploy preview 🚀
What kind of changes does this PR include?
Description
.mdxfiles for content..mdto.mdxmoving any imports out ofsetupin frontmatter and down the MDX body.Here’s a gist of the script I used to automate AFMD to MDX migration in case it’s useful to anyone.
||text||now only supports MDX as I couldn’t figure out how to make a micromark syntax-extension handle both MD & MDX.)To-do
<Content />that contains a fragment — 🚫 Currently blocked by Rendering<Content />fails for MDX file containing<Fragment>astro#5519For now, we’re setting the
NODE_OPTIONSenvironment variable to--max_old_space_size=4096to increase memory limits in both CI environments.<Aside />usage/custom syntax||spoiler syntax||