Skip to content

Routing updates (i18nIgnore)#6620

Merged
TheOtterlord merged 9 commits intomainfrom
sarah-logical-urls
Feb 1, 2024
Merged

Routing updates (i18nIgnore)#6620
TheOtterlord merged 9 commits intomainfrom
sarah-logical-urls

Conversation

@TheOtterlord
Copy link
Copy Markdown
Member

@TheOtterlord TheOtterlord commented Jan 25, 2024

Description (required)

Collaboration on talking & docing.

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 1, 2024 2:34pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Feb 1, 2024 2:34pm

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jan 25, 2024
@TheOtterlord TheOtterlord changed the title Routing updates Routing updates (i18nIgnore) Jan 25, 2024
@HiDeoo
Copy link
Copy Markdown
Member

HiDeoo commented Jan 25, 2024 •
edited
Loading

👋 Just adding myself a note to double check the French title of the sharing-state-islands page. Done, I think I just confused myself with the two pages in the Gitpod during the T&D session.

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Jan 25, 2024

Making a note to encourage people to leave thoughts as to what else maybe should change here at the same time!

e.g. Do we like the "Built ins" section, or just move those three items into guides?

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Jan 25, 2024

(I can't believe all the checks pass...)

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Jan 25, 2024

OOh, note to check Astro Docs Docs to see if we're linking to any URLs that would be affected, so we can clean them up at the source!

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Jan 25, 2024 •
edited
Loading

UPDATE: On today's Talking and Doc'ing we:

  • renamed src/content/docs/[lang]/core-concepts/ to src/content/docs/[lang]/basics/
  • renamed /[lang]/core-concepts/routing.mdx, /[lang]/core-concepts/endpoints.mdx, and /[lang]/core-concepts/framework-components.mdx all to /[lang]/guides/*.mdx
  • renamed /[lang]/core-concepts/sharing-state.mdx to /[lang]/recipes/sharing-state-islands.mdx
  • updated src/i18n/[lang]/nav.ts for the 3 files moved from core-concepts to guides folder
  • updated all internal links

TODO:
Vercel redirects for:

  • every file that previously started with /[lang]/core-concepts/ that is now in /[lang]/basics/

    • /[lang]/core-concepts/project-structure.mdx
    • /[lang]/core-concepts/astro-components.mdx
    • /[lang]/core-concepts/astro-pages.mdx
    • /[lang]/core-concepts/layouts.mdx
    • /[lang]/core-concepts/astro-syntax.mdx
    • /[lang]/core-concepts/rendering-modes.mdx

  • files that have moved to a new folder

  • /[lang]/core-concepts/routing.mdx to /[lang]/guides/routing.mdx

  • /[lang]/core-concepts/endpoints.mdx to /[lang]/guides/endpoints.mdx

  • /[lang]/core-concepts/framework-components.mdx to /[lang]/guides/framework-components.mdx

  • /[lang]/core-concepts/sharing-state.mdx to /[lang]/recipes/sharing-state-islands.mdx

@Fryuni
Copy link
Copy Markdown
Member

Fryuni commented Jan 25, 2024 •
edited
Loading

For reference these are the files Git is considering as renames:

`git diff --stat=200 --diff-filter=R main..sarah-logical-urls src/content/docs | rg -o -r '$1' '^ (.+\.mdx)'` 
src/content/docs/ar/{core-concepts => basics}/astro-components.mdx
src/content/docs/de/{core-concepts => basics}/astro-components.mdx
src/content/docs/de/{core-concepts => basics}/astro-pages.mdx
src/content/docs/de/{core-concepts => basics}/astro-syntax.mdx
src/content/docs/de/{core-concepts => basics}/layouts.mdx
src/content/docs/de/{core-concepts => basics}/project-structure.mdx
src/content/docs/de/{core-concepts => guides}/endpoints.mdx
src/content/docs/de/{core-concepts => guides}/framework-components.mdx
src/content/docs/de/{core-concepts => guides}/routing.mdx
src/content/docs/de/{core-concepts/sharing-state.mdx => recipes/sharing-state-islands.mdx
src/content/docs/en/{core-concepts => basics}/astro-components.mdx
src/content/docs/en/{core-concepts => basics}/astro-pages.mdx
src/content/docs/en/{core-concepts => basics}/astro-syntax.mdx
src/content/docs/en/{core-concepts => basics}/layouts.mdx
src/content/docs/en/{core-concepts => basics}/project-structure.mdx
src/content/docs/en/{core-concepts => basics}/rendering-modes.mdx
src/content/docs/en/{core-concepts => guides}/endpoints.mdx
src/content/docs/en/{core-concepts => guides}/framework-components.mdx
src/content/docs/en/{core-concepts => guides}/routing.mdx
src/content/docs/en/{core-concepts/sharing-state.mdx => recipes/sharing-state-islands.mdx
src/content/docs/es/{core-concepts => basics}/astro-components.mdx
src/content/docs/es/{core-concepts => basics}/astro-pages.mdx
src/content/docs/es/{core-concepts => basics}/astro-syntax.mdx
src/content/docs/es/{core-concepts => basics}/layouts.mdx
src/content/docs/es/{core-concepts => basics}/project-structure.mdx
src/content/docs/es/{core-concepts => basics}/rendering-modes.mdx
src/content/docs/es/{core-concepts => guides}/endpoints.mdx
src/content/docs/es/{core-concepts => guides}/framework-components.mdx
src/content/docs/es/{core-concepts => guides}/routing.mdx
src/content/docs/es/{core-concepts/sharing-state.mdx => recipes/sharing-state-islands.mdx
src/content/docs/fr/{core-concepts => basics}/astro-components.mdx
src/content/docs/fr/{core-concepts => basics}/astro-pages.mdx
src/content/docs/fr/{core-concepts => basics}/astro-syntax.mdx
src/content/docs/fr/{core-concepts => basics}/layouts.mdx
src/content/docs/fr/{core-concepts => basics}/project-structure.mdx
src/content/docs/fr/{core-concepts => basics}/rendering-modes.mdx
src/content/docs/fr/{core-concepts => guides}/endpoints.mdx
src/content/docs/fr/{core-concepts => guides}/framework-components.mdx
src/content/docs/fr/{core-concepts => guides}/routing.mdx
src/content/docs/fr/{core-concepts/sharing-state.mdx => recipes/sharing-state-islands.mdx
src/content/docs/it/{core-concepts => basics}/astro-components.mdx
src/content/docs/it/{core-concepts => basics}/astro-pages.mdx
src/content/docs/it/{core-concepts => basics}/astro-syntax.mdx
src/content/docs/it/{core-concepts => basics}/layouts.mdx
src/content/docs/it/{core-concepts => basics}/project-structure.mdx
src/content/docs/it/{core-concepts => basics}/rendering-modes.mdx
src/content/docs/it/{core-concepts => guides}/endpoints.mdx
src/content/docs/it/{core-concepts => guides}/framework-components.mdx
src/content/docs/it/{core-concepts => guides}/routing.mdx
src/content/docs/ja/{core-concepts => basics}/astro-components.mdx
src/content/docs/ja/{core-concepts => basics}/astro-pages.mdx
src/content/docs/ja/{core-concepts => basics}/astro-syntax.mdx
src/content/docs/ja/{core-concepts => basics}/layouts.mdx
src/content/docs/ja/{core-concepts => basics}/project-structure.mdx
src/content/docs/ja/{core-concepts => basics}/rendering-modes.mdx
src/content/docs/ja/{core-concepts => guides}/endpoints.mdx
src/content/docs/ja/{core-concepts => guides}/framework-components.mdx
src/content/docs/ja/{core-concepts => guides}/routing.mdx
src/content/docs/ko/{core-concepts => basics}/astro-components.mdx
src/content/docs/ko/{core-concepts => basics}/astro-pages.mdx
src/content/docs/ko/{core-concepts => basics}/astro-syntax.mdx
src/content/docs/ko/{core-concepts => basics}/layouts.mdx
src/content/docs/ko/{core-concepts => basics}/project-structure.mdx
src/content/docs/ko/{core-concepts => basics}/rendering-modes.mdx
src/content/docs/ko/{core-concepts => guides}/endpoints.mdx
src/content/docs/ko/{core-concepts => guides}/framework-components.mdx
src/content/docs/ko/{core-concepts => guides}/routing.mdx
src/content/docs/ko/{core-concepts/sharing-state.mdx => recipes/sharing-state-islands.mdx
src/content/docs/pt-br/{core-concepts => basics}/astro-components.mdx
src/content/docs/pt-br/{core-concepts => basics}/astro-pages.mdx
src/content/docs/pt-br/{core-concepts => basics}/astro-syntax.mdx
src/content/docs/pt-br/{core-concepts => basics}/layouts.mdx
src/content/docs/pt-br/{core-concepts => basics}/project-structure.mdx
src/content/docs/pt-br/{core-concepts => guides}/endpoints.mdx
src/content/docs/pt-br/{core-concepts => guides}/framework-components.mdx
src/content/docs/pt-br/{core-concepts => guides}/routing.mdx
src/content/docs/pt-br/{core-concepts/sharing-state.mdx => recipes/sharing-state-islands.mdx
src/content/docs/ru/{core-concepts => basics}/astro-components.mdx
src/content/docs/ru/{core-concepts => basics}/astro-pages.mdx
src/content/docs/ru/{core-concepts => basics}/astro-syntax.mdx
src/content/docs/ru/{core-concepts => basics}/layouts.mdx
src/content/docs/ru/{core-concepts => basics}/project-structure.mdx
src/content/docs/ru/{core-concepts => guides}/routing.mdx
src/content/docs/zh-cn/{core-concepts => basics}/astro-components.mdx
src/content/docs/zh-cn/{core-concepts => basics}/astro-pages.mdx
src/content/docs/zh-cn/{core-concepts => basics}/astro-syntax.mdx
src/content/docs/zh-cn/{core-concepts => basics}/layouts.mdx
src/content/docs/zh-cn/{core-concepts => basics}/project-structure.mdx
src/content/docs/zh-cn/{core-concepts => basics}/rendering-modes.mdx
src/content/docs/zh-cn/{core-concepts => guides}/endpoints.mdx
src/content/docs/zh-cn/{core-concepts => guides}/framework-components.mdx
src/content/docs/zh-cn/{core-concepts => guides}/routing.mdx
src/content/docs/zh-cn/{core-concepts/sharing-state.mdx => recipes/sharing-state-islands.mdx
src/content/docs/zh-tw/{core-concepts => basics}/astro-pages.mdx
src/content/docs/zh-tw/{core-concepts => basics}/layouts.mdx
src/content/docs/zh-tw/{core-concepts => basics}/project-structure.mdx

It seems to match up with what was written down during the call. I didn't spot anything missing.

I'll send a PR targeting this PR with the Vercel redirects in a bit

@Fryuni Fryuni mentioned this pull request Jan 26, 2024
Merged
@Fryuni @TheOtterlord
Add redirect for moved and renamed files (#6630)
802ad46 
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
@sarah11918 sarah11918 marked this pull request as ready for review February 1, 2024 13:40
@at-the-vr
Copy link
Copy Markdown
Member

at-the-vr commented Feb 1, 2024

Final comment before Check Links gives ✅. Nice to see routing is fixed 😄 Redirects working super quick

@sasoria
Copy link
Copy Markdown
Contributor

sasoria commented Feb 1, 2024

It was awesome to work on this together 🙌

@TheOtterlord TheOtterlord merged commit 467f5ce into main Feb 1, 2024
@TheOtterlord TheOtterlord deleted the sarah-logical-urls branch February 1, 2024 14:45
This was referenced Feb 1, 2024
Closed
Closed
@ninuzdellalb ninuzdellalb mentioned this pull request Feb 1, 2024
Merged
yanthomasdev added a commit that referenced this pull request Feb 5, 2024
@ninuzdellalb @yanthomasdev
i18n(it): Update nav.ts (#6745)
5a3d86b 
The file `nav.ts` has been updated to align with the English language documentation based on this commits #4876 , #5183 , #5213 , #5271 , #5187 , #4667 , #5541 , #5605 , #5499 , #6470 , #6620

Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
trueberryless added a commit to trueberryless/withastro-docs that referenced this pull request Oct 22, 2024
@trueberryless
update translation withastro#6620
1f58494
@trueberryless trueberryless mentioned this pull request Oct 22, 2024
Merged
yanthomasdev added a commit that referenced this pull request Nov 4, 2024
@trueberryless @Maxframe @yanthomasdev
i18n(de): update basics/astro-pages.mdx (#9759)
c478fe4 
* update translation #1442

* update translation #1434

* update translation #1510

* update translation #1538

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* update translation #1638

* update translation #2091

* update translation #2133

* update translation #2409

* update translation #2371

* update translation #4610

* update translation #5128

* update translation #5205

* update translation #5240

* update translation #5364

* update translation #5765

* update translation #6267

* remove paragraph where I cant find when it was deleted in original version

* update translation #6620

* update translation #8495

* update translation #8573

* update translation #9336

* update translation #9336 2/2

didnt save file locally, so git didnt add

* fix all visual differences by comparing manually against original english version

* fix broken links in `astro-pages.mdx`

* Breaking changes to other files! fixing links which link to the �stro-pages.mdx file

* but now...

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com>

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com>

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com>

* revert Update markdown-content.mdx

@lunaria-track:src/content/docs/de/basics/astro-pages.mdx

---------

Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@trueberryless trueberryless mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@TheOtterlord @HiDeoo @sarah11918 @Fryuni @at-the-vr @sasoria