Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
View Transitions Opening Statement has a typo in "....page transitions and animations, controling the brower’s history stack of visited pages and...." controlling should have 2 l's and I believe it should be browsers' history with the ' after the s not before. Aaaaand I did not see the comments above mine that already pointed this out. My apologies. Also I need to learn how to do the cool Github diff thing in these comments. lol. These are absolutely outstanding docs! Really well done and something to be quite proud of. |
freekrai
left a comment
There was a problem hiding this comment.
Looks good aside from that one “controling” as previously mentioned. 👍
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
bogdaaamn
left a comment
There was a problem hiding this comment.
Left just two code suggestions, otherwise the content LGTM 🚀
Typing mistake in collections tutorialit should prolly be "This leads to.." instead of "the* |
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
|
Looks pretty good! Here's a personal reword I would implement: Current wording 'You can instead follow these steps with your own Astro project, but you will need to adjust the instructions for your codebase.' Suggested wording 'Alternatively, you can follow along with your own Astro project. You'll just need to adjust the instructions for your codebase.' I'd also consider putting "Build a Blog" in quotes so that it's a little clearer that there's a distinction: Current wording 'Build a Blog Tutorial Code In the Build a Blog introductory tutorial...' Suggested wording '"Build a Blog" Tutorial Code In the "Build a Blog" introductory tutorial...' |
|
Looks great. 🚀 |
Co-authored-by: Voxel <voxelmc@hotmail.com>
Co-authored-by: Voxel <voxelmc@hotmail.com>
What kind of changes does this PR include?
Description
This PR adds two ways to extend the existing tutorial. Both are walkthroughs starting from the existing blog tutorial codebase, but are written in a way to be more generally relevant (with caveats that if you're not using this starting code, you will need to make adjustments, and we suggest following these shorter tutorials to learn, then apply to your own project.)
Preview: https://deploy-preview-4876--astro-docs-2.netlify.app/en/extend/add-content-collections/
Preview: https://deploy-preview-4876--astro-docs-2.netlify.app/en/extend/add-view-transitions/