Add i18n for screen reader section labels#2249
Merged
yanthomasdev merged 4 commits intomainfrom Dec 28, 2022
Merged
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
delucis
reviewed
Dec 28, 2022
Member
delucis
left a comment
There was a problem hiding this comment.
Clever solution! Shame rehype-autolink-headings doesn’t provide file etc. as context to its different methods so we could just plug this in there. Made a small naming suggestion & refactor recommendation.
LOVE that this is your first PR back — i18n + a11y in one go 🙌
Co-Authored-By: Chris Swithinbank <357379+delucis@users.noreply.github.com>
delucis
approved these changes
Dec 28, 2022
Member
delucis
left a comment
There was a problem hiding this comment.
LGTM! Welcome back @yan-thomas 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
This PR adds a new rehype plugin to translate the screen reader anchor labels injected by
rehype-autolink-headings. If the current language doesn't have a translation yet, it will fallback to English.