Skip to content

i18n(ja): Update routing.mdx in ja#7101

Merged
yanthomasdev merged 12 commits intowithastro:mainfrom
fhiromasa:patch-1
Mar 5, 2024
Merged

i18n(ja): Update routing.mdx in ja#7101
yanthomasdev merged 12 commits intowithastro:mainfrom
fhiromasa:patch-1

Conversation

@fhiromasa
Copy link
Copy Markdown
Contributor

@fhiromasa fhiromasa commented Feb 29, 2024

Modified to be similar to the English sample code in "Nested Pagination" section

Description (required)

The sample code for "nested pagination" in Japanese documents does not work properly.

Modified to be similar to the English sample code

The sample code in the English documentation worked

Sorry, I used translate.google.com service.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@fhiromasa
Update routing.mdx in ja
4de3728 
Modified to be similar to the English sample code in "Nested Pagination" section
@vercel
Copy link
Copy Markdown

vercel bot commented Feb 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 5, 2024 4:02pm

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Feb 29, 2024
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Feb 29, 2024

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@fhiromasa fhiromasa changed the title Update routing.mdx in ja i18n(ja): Update routing.mdx in ja Feb 29, 2024
@morinokami
Copy link
Copy Markdown
Member

morinokami commented Mar 2, 2024

@fhiromasa Thank you! ありがとうございます！

確認したところ、本変更自体は問題ないようなのですが、このファイルには他にも変更が積み重なっており（https://github.com/withastro/docs/commits/467f5ce70acf35158a022f36f63c712de187a13b/src/content/docs/en/core-concepts/routing.mdx?browsing_rename_history=true&new_path=src/content/docs/en/guides/routing.mdx&original_branch=main の #4476 以降）、基本的にはあるページを翻訳する際はこれらをすべて修正することになっています。fhiromasa さんの方で追加でこれらに取り掛かってもらうことは可能でしょうか？（難しそうであればこちらで引き受けますので、無理そうであっても全然大丈夫です）

@fhiromasa
Copy link
Copy Markdown
Contributor Author

fhiromasa commented Mar 3, 2024

@morinokami
確認ありがとうございます。

基本的にはあるページを翻訳する際はこれらをすべて修正することになっています

こちら認識から漏れていてすみませんでした。

私のほうで翻訳してみます。

@morinokami
Copy link
Copy Markdown
Member

morinokami commented Mar 3, 2024

@fhiromasa ありがとうございます、ではよろしくお願いします🙏

対象としては、

で、一番上は既に修正いただいているので、残りを順番に対応していただくと間違いがないかと思います。他のファイルの変更は無視して、このファイルのみの修正で OK です。

終わったら自分をレビュアーにアサインしてもらうか、声を掛けてもらえればこちらで確認します。なお、Discord にもいますので、そちらでも大丈夫です！

fhiromasa added 4 commits March 3, 2024 15:13
@fhiromasa
update routing.mdx in ja
bcdb042 
[code-example-syntax] hippo-proof code examples (withastro#5364)
@fhiromasa
update routing.mdx in ja
0e36aea 
fix: add spacing to 'added in' texts (withastro#5765)
@fhiromasa
update routing.mdx in ja
718dcb7 
Add <ReadMore> component (withastro#6267)
@fhiromasa
Update routing.mdx in ja
21e97b5 
Document new routing priority behavior (withastro#6386)
@fhiromasa fhiromasa marked this pull request as draft March 3, 2024 07:36
@fhiromasa
Copy link
Copy Markdown
Contributor Author

fhiromasa commented Mar 3, 2024 •
edited
Loading

@morinokami
修正完了しました。
確認おねがいします。

コミットメッセージの3行目に対象のプルリクエストを張り付けています。

@fhiromasa fhiromasa marked this pull request as ready for review March 3, 2024 07:43
morinokami
morinokami reviewed Mar 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@morinokami morinokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

素早く対応していただきありがとうございます、いくつかコメントしましたのでご確認をお願いします！

fhiromasa and others added 6 commits March 3, 2024 22:12
@fhiromasa @morinokami
Update src/content/docs/ja/guides/routing.mdx
cb9f402 
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
@fhiromasa @morinokami
Update src/content/docs/ja/guides/routing.mdx
b3878b3 
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
@fhiromasa @morinokami
Update src/content/docs/ja/guides/routing.mdx
1453262 
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
@fhiromasa @morinokami
Update src/content/docs/ja/guides/routing.mdx
147a176 
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
@fhiromasa @morinokami
Update src/content/docs/ja/guides/routing.mdx
40df2d1 
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
@fhiromasa @morinokami
Update src/content/docs/ja/guides/routing.mdx
6b66371 
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
@fhiromasa
Copy link
Copy Markdown
Contributor Author

fhiromasa commented Mar 3, 2024

@morinokami
丁寧なコメントありがとうございます！

すべての提案をコミットしました。

morinokami
morinokami approved these changes Mar 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@morinokami morinokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応いただきありがとうございました、LGTM!!

yanthomasdev
yanthomasdev approved these changes Mar 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @fhiromasa 🙌

@yanthomasdev yanthomasdev merged commit 5e59ee9 into withastro:main Mar 5, 2024
peng added a commit to peng/astro-docs that referenced this pull request Mar 6, 2024
@peng
Merge branch 'main' into add-multiple-cdn-v2
0526c1d 
* main: (55 commits)
  i18n(es): Update fonts.mdx (withastro#7199)
  i18n(es): Update images.mdx translation (withastro#7197)
  i18n(ru): Add `image-service-reference.mdx` translation (withastro#7202)
  i18n(it): Updated tutorials and small fix to install (withastro#7087)
  i18n(it): Updated basics (withastro#7088)
  i18n(it): Updated guides (withastro#7085)
  i18n(ja): Update `configuration-reference.mdx` (withastro#7158)
  i18n(ru): Update `islands.mdx` translation (withastro#7195)
  i18n(ru): Update `astro-syntax.mdx` translation (withastro#7187)
  i18n(ru): Update `tutorial/1-setup/2.mdx` translation (withastro#7186)
  i18n(pt-BR): Create `authentication.mdx` (withastro#6951)
  i18n(hi): add `astro-pages.mdx` (withastro#7003)
  i18n(ko-KR): add `ecommerce.mdx` (withastro#7149)
  i18n(ru): Update `fonts.mdx` translation (withastro#7166)
  i18n(ru): Update `recipes.mdx` translation (withastro#7165)
  i18n(ru): Update `migrate-to-astro.mdx` translation (withastro#7164)
  i18n(ja): Update routing.mdx in ja (withastro#7101)
  [i18nIgnore] Update 1.mdx
  i18n(fr): Update `guides/fonts.mdx` and `tutorial/1-setup/2.mdx` (withastro#7189)
  i18n(fr): Update `guides/images.mdx` and `guides/rss.mdx`  (withastro#7151)
  ...
@fhiromasa fhiromasa deleted the patch-1 branch May 21, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morinokami morinokami morinokami approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fhiromasa @astrobot-houston @morinokami @yanthomasdev