Skip to content

Document --host and --port flags for preview#6040

Merged
sarah11918 merged 2 commits intomainfrom
host-port-preview
Jan 3, 2024
Merged

Document --host and --port flags for preview#6040
sarah11918 merged 2 commits intomainfrom
host-port-preview

Conversation

@bluwy
Copy link
Copy Markdown
Member

@bluwy bluwy commented Jan 2, 2024

Description (required)

--host and --port works for astro preview for a very long time (since the command existed?). I moved the two flags under dev flags to common flags. And roughly updated the "dev server" phrase to "dev server and preview server".

Related issues & labels (optional)

  • Closes #
  • Suggested label:

The Astro core PR that updated the flags is withastro/astro#9572. We don't have to align the merge release with it though. I think it's more of missing docs.

@bluwy bluwy added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Jan 2, 2024
@vercel
Copy link
Copy Markdown

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 3, 2024 7:32pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2024 7:32pm

@VoxelMC
Copy link
Copy Markdown
Contributor

VoxelMC commented Jan 2, 2024

The change makes sense to me. Thank you bluwy :)

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And no need to wait for minor release here. Just adding it into the merge queue directly!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jan 3, 2024
@sarah11918 sarah11918 merged commit 1afe483 into main Jan 3, 2024
@sarah11918 sarah11918 deleted the host-port-preview branch January 3, 2024 19:33
dreyfus92 added a commit that referenced this pull request Jan 14, 2024
…mdx` (#6363)

* i18n(fr) Update reading-time.mdx

Just for translator tracker because the PR #5766 should have been [ignore]

* Update astro-pages.mdx

* Update framework-components.mdx

* Update layouts.mdx

* Update routing.mdx

* Update editor-setup.mdx

* Update configuring-astro.mdx

* Update cloudflare.mdx

* Update deno.mdx

* Update netlify.mdx

* Update vercel.mdx

* Update imports.mdx

* Update auto.mdx

* Update manual.mdx

* Update cli-reference.mdx

Update and del some parts

* Update cli-reference.mdx

Update fiule with PR #5512 #5651 #5604 #5765 #6040 #6043 #6109 #6267

* Update auto.mdx

* Update cloudflare.mdx

fix PR #5284

* Update markdown-content.mdx

* Update auto.mdx

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/core-concepts/framework-components.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/core-concepts/framework-components.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/guides/markdown-content.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/install/manual.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/install/manual.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/reference/cli-reference.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Apply suggestions from code review

---------

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
…mdx` (#6363)

* i18n(fr) Update reading-time.mdx

Just for translator tracker because the PR #5766 should have been [ignore]

* Update astro-pages.mdx

* Update framework-components.mdx

* Update layouts.mdx

* Update routing.mdx

* Update editor-setup.mdx

* Update configuring-astro.mdx

* Update cloudflare.mdx

* Update deno.mdx

* Update netlify.mdx

* Update vercel.mdx

* Update imports.mdx

* Update auto.mdx

* Update manual.mdx

* Update cli-reference.mdx

Update and del some parts

* Update cli-reference.mdx

Update fiule with PR #5512 #5651 #5604 #5765 #6040 #6043 #6109 #6267

* Update auto.mdx

* Update cloudflare.mdx

fix PR #5284

* Update markdown-content.mdx

* Update auto.mdx

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/core-concepts/framework-components.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/core-concepts/framework-components.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/guides/markdown-content.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/install/manual.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/install/manual.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Update src/content/docs/fr/reference/cli-reference.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* Apply suggestions from code review

---------

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants