updates all aside text to sentence case#5572
Merged
sarah11918 merged 6 commits intomainfrom Dec 3, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sarah11918
commented
Dec 3, 2023
sarah11918
commented
Dec 3, 2023
sarah11918
commented
Dec 3, 2023
sarah11918
commented
Dec 3, 2023
vasfvitor
approved these changes
Dec 3, 2023
Contributor
|
LGTM! |
sarah11918
commented
Dec 3, 2023
Co-authored-by: Vitor Ayres <vasfvitor@gmail.com>
This was referenced Jan 2, 2024
ematipico
pushed a commit
that referenced
this pull request
Jan 26, 2024
Co-authored-by: Vitor Ayres <vasfvitor@gmail.com>
trueberryless
added a commit
to trueberryless/withastro-docs
that referenced
this pull request
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
This changes all of our aside (e.g. "tip", "note" etc.) custom titles to sentence case.
The Astro Docs site automatically converts all text written as a
:::note[custom title]to uppercase, as a design choice.Starlight, however, displays text exactly as written. Moreover, the design choice for Starlight is to NOT show this text as all upper case. So, existing asides had to be checked to make sure all custom title text was written in sentence case.
We used @vasfvitor 's find and replace algorithm to convert every custom title to sentence case, then manually inspected for proper nouns (e.g. Astro, StackBlitz, RSS) and manually added capitals.