Skip to content

Add additional explanation about define:vars directive#8585

Merged
sarah11918 merged 3 commits intowithastro:mainfrom
ArmandPhilippot:doc/add-define-vars-info
Jun 19, 2024
Merged

Add additional explanation about define:vars directive#8585
sarah11918 merged 3 commits intowithastro:mainfrom
ArmandPhilippot:doc/add-define-vars-info

Conversation

@ArmandPhilippot
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot commented Jun 19, 2024

Description (required)

I added additional information about define:vars directive on two pages:

The define:vars directive does not work with dynamic tags and I have seen some issues related to that on the main repository so I think it should be clarified.

The statement was not exact since, as stated in #3165: using define:vars on <style /> tag does not automatically apply the is:inline directive.

Related issues & labels (optional)

First-time contributor to Astro Docs?

ar_phi

(I'm not often connected... but I should get an email when mentioned if needed.)

@vercel
Copy link
Copy Markdown

vercel bot commented Jun 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 19, 2024 9:42pm
docs-i18n 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 9:42pm

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jun 19, 2024

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jun 19, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en basics/astro-syntax.mdx Source changed, localizations will be marked as outdated.
en reference/directives-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@ArmandPhilippot ArmandPhilippot mentioned this pull request Jun 19, 2024
Closed
sarah11918
sarah11918 reviewed Jun 19, 2024
View reviewed changes
sarah11918
sarah11918 approved these changes Jun 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @ArmandPhilippot and I really appreciate you taking the time both to point out the issues and suggested fixes and to come and make a PR to improve the documentation. Welcome to Team Docs! 🥳

@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Jun 19, 2024
@sarah11918 sarah11918 merged commit a14dce7 into withastro:main Jun 19, 2024
@ArmandPhilippot ArmandPhilippot deleted the doc/add-define-vars-info branch June 19, 2024 21:58
This was referenced Jun 19, 2024
Merged
Merged
@liruifengv liruifengv mentioned this pull request Jun 20, 2024
Merged
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Jun 21, 2024
@ArmandPhilippot
i18n(fr): update astro-syntax.mdx & directives-reference.mdx
4767180 
* translate the two pages updated in withastro#8585
* fix two typo (plural and verb agreement)
@ArmandPhilippot ArmandPhilippot mentioned this pull request Jun 21, 2024
Merged
yanthomasdev added a commit that referenced this pull request Jun 25, 2024
@ArmandPhilippot @thomasbnt @yanthomasdev
i18n(fr): update astro-syntax.mdx & directives-reference.mdx (#8626)
fbc2322 
* translate the two pages updated in #8585
* fix two typo (plural and verb agreement)

-----
Co-authored-by: Thomas Bonnet <14293805+thomasbnt@users.noreply.github.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@at-the-vr at-the-vr mentioned this pull request Aug 8, 2024
Merged
@sarah11918 sarah11918 added the feedback-improvement Response to widget/Discord feedback label Aug 14, 2024
trueberryless added a commit to trueberryless/withastro-docs that referenced this pull request Oct 30, 2024
@trueberryless
update translation withastro#8585
970e6ce
@trueberryless trueberryless mentioned this pull request Oct 30, 2024
Merged
yanthomasdev added a commit that referenced this pull request Nov 4, 2024
@trueberryless @yanthomasdev
i18n(de): update basics/astro-syntax.mdx (#9886)
c22591c 
* update translation #5364

* update translation #5572

* update translation #8585

* update translation #9082

---------

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@vrabe vrabe mentioned this pull request Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

feedback-improvement Response to widget/Discord feedback improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a warning about dynamic tags and reword another in Template Directives

3 participants

@ArmandPhilippot @astrobot-houston @sarah11918