[i18nIgnore] Add tab component to recipes and deploy.mdx#5305
[i18nIgnore] Add tab component to recipes and deploy.mdx#5305sarah11918 merged 16 commits intomainfrom unknown repository
deploy.mdx#5305Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
deploy.mdx
As far as I can tell I updated these for every available language. And, the CI on check links is just a fluke and should work fine if the test is rerun. |
at-the-vr
left a comment
There was a problem hiding this comment.
I ran the changes and found all of the changes in deploy.mdx files & es/recipes/external-links return a MDXError
I found only fix being just formatting the PackageManagerTabs Snippet similar as any of the add-yaml-support.mdx or any file that uses PackageManagerTabs (en/install/auto for example) changes
| ```bash | ||
| npm install --global netlify-cli | ||
| ``` | ||
| <PackageManagerTabs> | ||
| <Fragment slot="npm"> | ||
| ```shell | ||
| npm install --global netlify-cli | ||
| ``` | ||
| </Fragment> | ||
| <Fragment slot="pnpm"> | ||
| ```shell | ||
| pnpm add --global netlify-cli | ||
| ``` | ||
| </Fragment> | ||
| <Fragment slot="yarn"> | ||
| ```shell | ||
| yarn global add netlify-cli | ||
| ``` | ||
| </Fragment> | ||
| </PackageManagerTabs> |
There was a problem hiding this comment.
Changes involving ordered list currently are not looking right.
As an example: https://deploy-preview-5305--astro-docs-2.netlify.app/en/guides/deploy/
The CLI command area should be a child of the ordered list, currently it's being rendered as a sibling element between two ordered lists.
You can add indentation to make it render as a child:
-<PackageManagerTabs>
- <Fragment slot="npm">
- ```shell
- npm install --global netlify-cli
- ```
- </Fragment>
- <Fragment slot="pnpm">
- ```shell
- pnpm add --global netlify-cli
- ```
- </Fragment>
- <Fragment slot="yarn">
- ```shell
- yarn global add netlify-cli
- ```
- </Fragment>
- </PackageManagerTabs>
+ <PackageManagerTabs>
+ <Fragment slot="npm">
+ ```shell
+ npm install --global netlify-cli
+ ```
+ </Fragment>
+ <Fragment slot="pnpm">
+ ```shell
+ pnpm add --global netlify-cli
+ ```
+ </Fragment>
+ <Fragment slot="yarn">
+ ```shell
+ yarn global add netlify-cli
+ ```
+ </Fragment>
+ </PackageManagerTabs>There was a problem hiding this comment.
This one is well put, I will stick with these as well. Thanks @Genteure 😄
TheOtterlord
left a comment
There was a problem hiding this comment.
Thanks for the PR @jacobthesheep! 🎉
It looks like there are issues with the indenting of tabs in lists.
Once corrected, they should be part of the list indent.
I've suggested one example of correct indenting. You can view the indenting in the Netlify deploy preview once you've committed your changes. Once you have updated all the changes, we can take another look!
Co-authored-by: Atharva Pise <atharvapise19@gmail.com>
Co-authored-by: Atharva Pise <atharvapise19@gmail.com>
Should be fixed now! |
|
Hey @jacobthesheep ! The indenting looks good on all the pages except the "external links" one. Do you mind taking another look at that, and then I'm happy to get this one merged! 🚀 |
Got it! |
|
Looking great now! Let's jump this one into the merge queue! 🚋 |
Description (required)
Add a tab component to the remaining recipe pages and
deploy.mdx.Related issues & labels (optional)