Merged
Conversation
Contributor
tac0turtle
commented
Sep 19, 2019
- Referenced an issue explaining the need for the change
- Updated all relevant documentation in docs
- Updated all code comments where relevant
- Wrote tests
- Updated CHANGELOG_PENDING.md
+ Include an implementaiton of the routines specified in ADR-43
along with a demuxer and some dummy reactor code
+ `routine.send` returns false when routine is not running
+ this will prevent panics sending to channels which have been
closed
+ Make output channels routine specific removing the risk of someone
writting to a channel which was closed by another touine.
+ consistency changes between the routines and the demuxer
+ ensure that we stop accepting messages once `stop` has been called
to avoid the case in which we attempt to write to a channel which
has already been closed
+ use `trySend` the replicate peer sending
+ expose `next()` as a chan of events as output
+ expose `final()` as a chan of error, for the final error
+ add `ready()` as chan struct when routine is ready
+ close `rdy` channel to ensure that calls to `<-ready()` will
always return if the routine is ready
…#3933) - switch the data that was represented in `/unconfirmed_txs` and `num_unconfirmed_txs` Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* Create development_sessions * Rename development_sessions to videos_development_sessions * Update videos_development_sessions * Rename videos_development_sessions to videos_development_sessions_md * Delete videos_development_sessions_md * Add files via upload
* docs: move dev sessions into docs and transform the list into a table * fix formatting
* update gogo/protobuf version from v1.2.1 to v1.3.0 Also errcheck from v1.1.0 to v1.2.0 See full diff in - gogo/protobuf@v1.2.1...v1.3.0 - kisielk/errcheck@v1.1.0...v1.2.0 Changelog: Tested versions: go 1.12.9 protoc 3.7.1 Improvements: plugin/stringer - Handle repeated and/or nullable types a bit better now. plugin/size - Remove the loop in sovXXX by using bit twiddling. Thanks: https://github.com/apelisse plugin/marshalto - Implemented a reverse marshal strategy which allows for faster marshalling. This now avoids a recursive (and repeated) call to Size(). Thanks: https://github.com/apelisse plugin/compare - Added support for for oneof types. Bug fixes: protoc-gen-gogo/generator - Fix assignment to entry in nil map. Thanks: https://github.com/tgulacsi protoc-gen-gogo/generator - Allows plugins to call RecordTypeUse without panicking. Thanks: https://github.com/fedenusy proto/extensions - Fixed set extension regression. We did not clear the extensions before setting. io/uint32 - fix uint32reader bug that causes ReadMsg to recreate buffer when lengths are the same. Thanks: https://github.com/SebiSujar proto/table_merge: Fix merge of non-nullable slices. Thanks: https://github.com/euroelessar Upstream commits: merged in golang/protobuf commit 318d17de72747ed1c16502681db4b2bb709a92d0 - Add UnimplementedServer for server interface merged in golang/protobuf commit b85cd75de734650db18a99a943fe351d41387800 - protoc-gen-go/grpc: inline errUnimplemented function merged in golang/protobuf commit d3c38a4eb4970272b87a425ae00ccc4548e2f9bb - protoc-gen-go/grpc: use status and code packages only if needed merged in golang/protobuf commit e91709a02e0e8ff8b86b7aa913fdc9ae9498e825 - fix indentation in jsonpb with Any messages merged in golang/protobuf commit 8d0c54c1246661d9a51ca0ba455d22116d485eaa - protoc-gen-go: generate XXX_OneofWrappers instead of XXX_OneofFuncs Misc: extensions.md - Markdown update. Thanks: https://github.com/TennyZhuang Readme.md - Added user. go/protoc update - Updated to go1.12.x and protoc 3.7.1 Makefile update - fix go vet shadow tool reference test/mixbench - Update mixbench tool. Expose runnable benchmarks via flags. * update certstrap * update golangci-lint from v1.13.2 to v1.17.1 * update gox as well * test * comment out golangci temporary * comment out go-deadlock deps
Bumps [github.com/magiconair/properties](https://github.com/magiconair/properties) from 1.8.0 to 1.8.1. - [Release notes](https://github.com/magiconair/properties/releases) - [Changelog](https://github.com/magiconair/properties/blob/master/CHANGELOG.md) - [Commits](magiconair/properties@v1.8.0...v1.8.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [github.com/rs/cors](https://github.com/rs/cors) from 1.6.0 to 1.7.0. - [Release notes](https://github.com/rs/cors/releases) - [Commits](rs/cors@v1.6.0...v1.7.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [github.com/fortytw2/leaktest](https://github.com/fortytw2/leaktest) from 1.2.0 to 1.3.0. - [Release notes](https://github.com/fortytw2/leaktest/releases) - [Commits](fortytw2/leaktest@v1.2.0...v1.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [github.com/libp2p/go-buffer-pool](https://github.com/libp2p/go-buffer-pool) from 0.0.1 to 0.0.2. - [Release notes](https://github.com/libp2p/go-buffer-pool/releases) - [Commits](libp2p/go-buffer-pool@v0.0.1...v0.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.22.0 to 1.23.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.22.0...v1.23.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.2.0 to 1.4.1. - [Release notes](https://github.com/gorilla/websocket/releases) - [Commits](gorilla/websocket@v1.2.0...v1.4.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
- depndabot couldnt update a few deps as they needed to beupdated together. - PRs: #3946, 3938 can be closed with this PR Signedoff-by: Marko Baricevic <marbar3778@yahoo.com>
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.3.0 to 1.4.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.3.0...v1.4.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [github.com/go-kit/kit](https://github.com/go-kit/kit) from 0.6.0 to 0.9.0. - [Release notes](https://github.com/go-kit/kit/releases) - [Commits](go-kit/kit@v0.6.0...v0.9.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
fixes #2010 * allow using a custom http client in rpc client * add tests and fix bug * fix confusion between remote and address * parse remote inside NewJSONRPCClientWithHTTPClient * cleanups * add warnings * add changelog entry * Update CHANGELOG_PENDING.md Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>
* Add fork scenarios * Add more details about varios attack cases * added more structure to the attack scenarios * Update docs/spec/consensus/fork-accountability.md Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com> * Update docs/spec/consensus/fork-accountability.md Co-Authored-By: Anca Zamfir <ancazamfir@users.noreply.github.com> * Update docs/spec/consensus/fork-accountability.md Co-Authored-By: Anca Zamfir <ancazamfir@users.noreply.github.com> * Update docs/spec/consensus/fork-accountability.md Co-Authored-By: Anca Zamfir <ancazamfir@users.noreply.github.com> * Update docs/spec/consensus/fork-accountability.md Co-Authored-By: Anca Zamfir <ancazamfir@users.noreply.github.com> * Update docs/spec/consensus/fork-accountability.md Co-Authored-By: Anca Zamfir <ancazamfir@users.noreply.github.com> * Update docs/spec/consensus/fork-accountability.md Co-Authored-By: Anca Zamfir <ancazamfir@users.noreply.github.com> * Update docs/spec/consensus/fork-accountability.md Co-Authored-By: Anca Zamfir <ancazamfir@users.noreply.github.com> * Update docs/spec/consensus/fork-accountability.md Co-Authored-By: Anca Zamfir <ancazamfir@users.noreply.github.com> * consensus properties explained * added question on conflicting proposals * misbehavior * misbehave * more misbehavior * table discussion * Add few clarifications
…3960) * Remove unnecessary type conversions * Consolidate repeated strings into consts * Clothe return statements * Update blockchain/v1/reactor_fsm_test.go Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com> This PR repairs linter errors seen when running the following commands: golangci-lint run --no-config --disable-all=true --enable=unconvert golangci-lint run --no-config --disable-all=true --enable=goconst golangci-lint run --no-config --disable-all=true --enable=nakedret Contributes to #3262
…#3928) * cs: check for SkipTimeoutCommit or wait timeout in handleTxsAvailable Previously, if create_empty_blocks was set to false, TM sometimes could create 2 consecutive blocks without actually waiting for timeoutCommit (1 sec. by default). ``` I[2019-08-29|07:32:43.874] Executed block module=state height=47 validTxs=10 invalidTxs=0 I[2019-08-29|07:32:43.876] Committed state module=state height=47 txs=10 appHash=F88C010000000000 I[2019-08-29|07:32:44.885] Executed block module=state height=48 validTxs=2 invalidTxs=0 I[2019-08-29|07:32:44.887] Committed state module=state height=48 txs=2 appHash=FC8C010000000000 I[2019-08-29|07:32:44.908] Executed block module=state height=49 validTxs=8 invalidTxs=0 I[2019-08-29|07:32:44.909] Committed state module=state height=49 txs=8 appHash=8C8D010000000000 I[2019-08-29|07:32:45.886] Executed block module=state height=50 validTxs=2 invalidTxs=0 I[2019-08-29|07:32:45.895] Committed state module=state height=50 txs=2 appHash=908D010000000000 I[2019-08-29|07:32:45.908] Executed block module=state height=51 validTxs=8 invalidTxs=0 I[2019-08-29|07:32:45.909] Committed state module=state height=51 txs=8 appHash=A08D010000000000 ``` This commit fixes that by adding a check to handleTxsAvailable. Fixes #3908 * update changelog * schedule timeoutCommit if StartTime is in the future or SkipTimeoutCommit=true && we DON'T have all the votes * fix TestReactorCreatesBlockWhenEmptyBlocksFalse by checking if we have LastCommit or not * address Ethan's comments
- goimports is not used as a tool anymore - correct me if wrong - rename devtools folder to merely tools.mk - remove slate_header.txt Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
- Added a deprecation warining in for deprecation of tm-bench in favor of tm-load-test - With the merging of this pr we can close tm-bench related issues. Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
* Remove omitempty from *pb.go - remove omitempty from *pb.go files - added command to makefile for everytime `make protoc_all` is run - open question: - Do we want to further remove omitempty from other places - https://github.com/tendermint/tendermint/blob/master/rpc/lib/types/types.go#L151 - and other places ref #3882 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * bring back omitempty to *pb.go * Update types/tx.go * custom marshlers * undo benchmark `omitepmty` * golangci lint fix * cleanup comments * changelog_pending entry
…m/tendermint/tendermint into brapse/blockchain-v2-riri-routine
…utine [blockchain] v2 Routines
protoc 3.7.0 gogo v1.3.0
- Release candidate for v0.32.4 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
) Bumps [github.com/tendermint/tm-db](https://github.com/tendermint/tm-db) from 0.1.1 to 0.2.0. - [Release notes](https://github.com/tendermint/tm-db/releases) - [Changelog](https://github.com/tendermint/tm-db/blob/master/CHANGELOG.md) - [Commits](tendermint/tm-db@v0.1.1...v0.2.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
golangcibot
reviewed
Sep 19, 2019
| } | ||
| } | ||
|
|
||
| func (rt *Routine) setLogger(logger log.Logger) { |
Contributor
There was a problem hiding this comment.
U1000: func (*Routine).setLogger is unused (from unused)
Codecov Report
@@ Coverage Diff @@
## v0.32 #4002 +/- ##
========================================
Coverage ? 66.68%
========================================
Files ? 225
Lines ? 18730
Branches ? 0
========================================
Hits ? 12490
Misses ? 5309
Partials ? 931
|
Contributor
|
Looks great. Can/should we add an entry under Also seems a few external contribs are missing? PSalant726, gchaincl |
tac0turtle
added a commit
that referenced
this pull request
Sep 19, 2019
5 tasks
ebuchman
approved these changes
Sep 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.