Skip to content

Creating 1 block per Tx when create_empty_block flag set to false #3908

@b00f

Description

@b00f

Tendermint version : 0.32.0
Environment: Linux

  • OS: Debian
  • Install tools: go mod ...

What happened:
1- Set create_empty_block to false to not create empty block when there is no transaction in mempool
2- Try to send 10 txs simultaneously
3- Tendermint creates 10 (or 9) blocks very fast and there is only 1 (or maybe 2) txs in each block

What you expected to happen:

  • Tendermint should wait for commit timeout after recieving first tx, Then notifying consensus engine
  • Tendermint should create 1 block with 10 txs

Have you tried the latest version: no

Logs (paste a small part showing an error (< 10 lines) or link a pastebin, gist, etc. containing more of the log file):

notifyTxsAvailable:  size: 1, notifiedTxsAvailable: false
I[2019-08-22|15:30:10.519] Executed block                               module=state height=12 validTxs=1 invalidTxs=0
I[2019-08-22|15:30:10.524] Committed state                              module=state height=12 txs=1 appHash=1F1FA71E94F5D63C667BAD9611440A1FBAEE5D6436970250EDAD3FD27A0CCC0B
notifyTxsAvailable:  size: 1, notifiedTxsAvailable: false
I[2019-08-22|15:30:10.577] Executed block                               module=state height=13 validTxs=1 invalidTxs=0
I[2019-08-22|15:30:10.583] Committed state                              module=state height=13 txs=1 appHash=3911B0BB1BF87887EB2AF66C5874F87D1888A501F8A8DE033107C31EB7D5FA0C
notifyTxsAvailable:  size: 1, notifiedTxsAvailable: false
I[2019-08-22|15:30:10.648] Executed block                               module=state height=14 validTxs=1 invalidTxs=0
notifyTxsAvailable:  size: 2, notifiedTxsAvailable: true
I[2019-08-22|15:30:10.654] Committed state                              module=state height=14 txs=1 appHash=13C195F3C26CC8E2B28DF661BAC2BCC6F73FEADEE888C252AC2F3AF887CDF212
resCbRecheck:  size: 1, notifiedTxsAvailable: false
notifyTxsAvailable:  size: 1, notifiedTxsAvailable: false
notifyTxsAvailable:  size: 2, notifiedTxsAvailable: true
I[2019-08-22|15:30:10.706] Executed block                               module=state height=15 validTxs=1 invalidTxs=0
I[2019-08-22|15:30:10.711] Committed state                              module=state height=15 txs=1 appHash=F29E4CFAB19BBBEF5DE73221FCF2018379D044D2AF247B205324AC7AE279C4A6
resCbRecheck:  size: 1, notifiedTxsAvailable: false
notifyTxsAvailable:  size: 1, notifiedTxsAvailable: false
notifyTxsAvailable:  size: 2, notifiedTxsAvailable: true
I[2019-08-22|15:30:10.763] Executed block                               module=state height=16 validTxs=1 invalidTxs=0
I[2019-08-22|15:30:10.769] Committed state                              module=state height=16 txs=1 appHash=8B4F0B069401A9989228DEE1A7DC6884D645A225E98D6B6F044E8E044E6C4774
resCbRecheck:  size: 1, notifiedTxsAvailable: false
notifyTxsAvailable:  size: 1, notifiedTxsAvailable: false
I[2019-08-22|15:30:10.824] Executed block                               module=state height=17 validTxs=1 invalidTxs=0
I[2019-08-22|15:30:10.830] Committed state                              module=state height=17 txs=1 appHash=59ADE0060E4859DDF2A8FAE356B0421B35C7A26766D75D28E385655B4F785C0C
I[2019-08-22|15:30:15.870] Executed block                               module=state height=18 validTxs=0 invalidTxs=0
I[2019-08-22|15:30:15.874] Committed state                              module=state height=18 txs=0 appHash=59ADE0060E4859DDF2A8FAE356B0421B35C7A26766D75D28E385655B4F785C0C

Config (you can paste only the changes you've made):
create_empty_blocks = false

Metadata

Metadata

Assignees

No one assigned

    Labels

    C:mempoolComponent: MempoolT:bugType Bug (Confirmed)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions