Skip to content

Minor cleanup of makefile#3994

Merged
melekes merged 1 commit intomasterfrom
marko/minor-make-cleanup
Sep 18, 2019
Merged

Minor cleanup of makefile#3994
melekes merged 1 commit intomasterfrom
marko/minor-make-cleanup

Conversation

@tac0turtle
Copy link
Contributor

  • goimports is not used as a tool anymore
    • correct me if wrong
  • rename devtools folder to merely tools.mk
  • remove slate_header.txt

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

- goimports is not used as a tool anymore
	- correct me if wrong
- rename devtools folder to merely tools.mk
- remove slate_header.txt

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@45ddd67). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3994   +/-   ##
=========================================
  Coverage          ?   66.88%           
=========================================
  Files             ?      219           
  Lines             ?    18486           
  Branches          ?        0           
=========================================
  Hits              ?    12365           
  Misses            ?     5198           
  Partials          ?      923

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melekes melekes merged commit 9d4a480 into master Sep 18, 2019
@melekes melekes deleted the marko/minor-make-cleanup branch September 18, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants