Skip to content

Add Deprecation warning in tm-bench#3992

Merged
melekes merged 2 commits intomasterfrom
marko/tm-bench_Deprication
Sep 18, 2019
Merged

Add Deprecation warning in tm-bench#3992
melekes merged 2 commits intomasterfrom
marko/tm-bench_Deprication

Conversation

@tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Sep 17, 2019

  • Added a deprecation warining in for deprecation of tm-bench in favor of tm-load-test

  • With the merging of this pr we can close tm-bench related issues.

  • once we have removed tm-bench then will add docs to direct users to tm-load-test

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

- Added a deprecation warining in for deprecation of tm-bench in favor of tm-load-test

- With the merging of this pr we can close tm-bench related issues.

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #3992 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3992      +/-   ##
==========================================
+ Coverage   66.94%   66.99%   +0.05%     
==========================================
  Files         219      219              
  Lines       18486    18486              
==========================================
+ Hits        12375    12385      +10     
+ Misses       5187     5180       -7     
+ Partials      924      921       -3
Impacted Files Coverage Δ
consensus/reactor.go 79.36% <0%> (-0.12%) ⬇️
blockchain/v0/pool.go 80.98% <0%> (+0.32%) ⬆️
p2p/pex/pex_reactor.go 84.34% <0%> (+1.73%) ⬆️
privval/signer_endpoint.go 84% <0%> (+2.66%) ⬆️
privval/signer_server.go 100% <0%> (+4.34%) ⬆️

@melekes melekes merged commit 98b91ce into master Sep 18, 2019
@melekes melekes deleted the marko/tm-bench_Deprication branch September 18, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants