Skip to content

RC1 - 0.32.4#4000

Merged
ebuchman merged 1 commit intorelease/v0.32.4from
rc1-v0.32.4
Sep 19, 2019
Merged

RC1 - 0.32.4#4000
ebuchman merged 1 commit intorelease/v0.32.4from
rc1-v0.32.4

Conversation

@tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Sep 19, 2019

  • Release candidate for v0.32.4

once this is finalized, will branch off and create the release branch and we can close this.

  • waiting on release of tm-db

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@tac0turtle tac0turtle requested a review from melekes September 19, 2019 08:54
@tac0turtle tac0turtle self-assigned this Sep 19, 2019
@codecov-io
Copy link

codecov-io commented Sep 19, 2019

Codecov Report

Merging #4000 into release/v0.32.4 will decrease coverage by 0.1%.
The diff coverage is 0%.

@@                Coverage Diff                 @@
##           release/v0.32.4   #4000      +/-   ##
==================================================
- Coverage             66.8%   66.7%   -0.11%     
==================================================
  Files                  225     225              
  Lines                18739   18737       -2     
==================================================
- Hits                 12519   12498      -21     
- Misses                5293    5308      +15     
- Partials               927     931       +4
Impacted Files Coverage Δ
blockchain/v2/routine.go 87.87% <ø> (ø) ⬆️
blockchain/v2/reactor.go 59.64% <0%> (-4.76%) ⬇️
privval/signer_server.go 95.65% <0%> (-4.35%) ⬇️
consensus/ticker.go 91.66% <0%> (-4.17%) ⬇️
privval/signer_endpoint.go 81.33% <0%> (-2.67%) ⬇️
consensus/state.go 79.31% <0%> (-1.06%) ⬇️
consensus/reactor.go 78.19% <0%> (-0.94%) ⬇️
blockchain/v0/pool.go 80.65% <0%> (-0.33%) ⬇️
p2p/pex/pex_reactor.go 84.34% <0%> (ø) ⬆️
... and 2 more

@melekes
Copy link
Contributor

melekes commented Sep 19, 2019

update version/version.go?

@tac0turtle tac0turtle changed the base branch from master to release/v0.32.4 September 19, 2019 12:35
@ebuchman ebuchman merged commit bf989eb into release/v0.32.4 Sep 19, 2019
@ebuchman ebuchman deleted the rc1-v0.32.4 branch September 19, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants