Skip to content

Update go.sum#3967

Merged
tac0turtle merged 1 commit intomasterfrom
mircea/update-go-sum
Sep 10, 2019
Merged

Update go.sum#3967
tac0turtle merged 1 commit intomasterfrom
mircea/update-go-sum

Conversation

@mircea-c
Copy link

@mircea-c mircea-c commented Sep 9, 2019

gorilla/websocket was updated in the go.mod file and pushed to git before running go mod tidy

This breaks dependency caching in CI and needs to be fixed.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@mircea-c mircea-c added the T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Sep 9, 2019
@mircea-c mircea-c requested a review from tac0turtle September 9, 2019 16:59
@mircea-c mircea-c self-assigned this Sep 9, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@22000c6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3967   +/-   ##
=========================================
  Coverage          ?   66.87%           
=========================================
  Files             ?      219           
  Lines             ?    18478           
  Branches          ?        0           
=========================================
  Hits              ?    12358           
  Misses            ?     5197           
  Partials          ?      923

@tac0turtle tac0turtle merged commit 7f0c55f into master Sep 10, 2019
@tac0turtle tac0turtle deleted the mircea/update-go-sum branch September 10, 2019 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants