Skip to content

docs: move dev sessions into docs#3934

Merged
melekes merged 2 commits intomasterfrom
anton/dev_sessions
Sep 3, 2019
Merged

docs: move dev sessions into docs#3934
melekes merged 2 commits intomasterfrom
anton/dev_sessions

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Sep 3, 2019

and transform the list into a table

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

and transform the list into a table
@melekes melekes requested review from ebuchman and xla as code owners September 3, 2019 07:49
Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:zap

@codecov-io
Copy link

codecov-io commented Sep 3, 2019

Codecov Report

Merging #3934 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3934      +/-   ##
==========================================
- Coverage   67.04%   66.88%   -0.16%     
==========================================
  Files         219      219              
  Lines       18207    18207              
==========================================
- Hits        12207    12178      -29     
- Misses       5118     5140      +22     
- Partials      882      889       +7
Impacted Files Coverage Δ
p2p/pex/pex_reactor.go 82.02% <0%> (-1.74%) ⬇️
consensus/reactor.go 77.84% <0%> (-1.53%) ⬇️
consensus/state.go 80.07% <0%> (-1.07%) ⬇️
rpc/client/httpclient.go 67.88% <0%> (-0.82%) ⬇️
consensus/replay.go 70.96% <0%> (-0.81%) ⬇️
p2p/conn/connection.go 80.97% <0%> (+0.25%) ⬆️
privval/signer_server.go 95.65% <0%> (+4.34%) ⬆️

@melekes melekes merged commit acb874e into master Sep 3, 2019
@melekes melekes deleted the anton/dev_sessions branch September 3, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants