deps: bump viper to 1.4.0 and logfmt to 0.4.0#3950
Merged
Conversation
- depndabot couldnt update a few deps as they needed to beupdated together. - PRs: #3946, 3938 can be closed with this PR Signedoff-by: Marko Baricevic <marbar3778@yahoo.com>
This was referenced Sep 4, 2019
tac0turtle
commented
Sep 4, 2019
| logger.Info("foo", "baz baz", "bar") | ||
| msg := strings.TrimSpace(buf.String()) | ||
| if !strings.Contains(msg, logfmt.ErrInvalidKey.Error()) { | ||
| if !strings.Contains(msg, "foo") { |
Contributor
Author
There was a problem hiding this comment.
tac0turtle
commented
Sep 4, 2019
| github.com/spf13/jwalterweatherman v1.0.0 // indirect | ||
| github.com/spf13/pflag v1.0.3 // indirect | ||
| github.com/spf13/viper v1.0.0 | ||
| github.com/spf13/viper v1.4.0 |
Contributor
Author
There was a problem hiding this comment.
all these changes came from upgrading this version of viper
Codecov Report
@@ Coverage Diff @@
## master #3950 +/- ##
==========================================
- Coverage 67% 66.95% -0.05%
==========================================
Files 219 219
Lines 18473 18458 -15
==========================================
- Hits 12377 12359 -18
+ Misses 5179 5177 -2
- Partials 917 922 +5
|
melekes
reviewed
Sep 5, 2019
| github.com/aead/siphash v1.0.1/go.mod h1:Nywa3cDsYNNK3gaciGTWPwHt0wlpNV15vwmswBAUSII= | ||
| github.com/alecthomas/template v0.0.0-20160405071501-a0175ee3bccc/go.mod h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc= | ||
| github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf/go.mod h1:ybxpYRFXyAe+OPACYpWeL0wqObRcbAqCMya13uyzqw0= | ||
| github.com/armon/consul-api v0.0.0-20180202201655-eb2c6b5be1b6/go.mod h1:grANhF5doyWs3UAsr3K4I6qtAmlQcZDesFNEHPZAzj8= |
melekes
reviewed
Sep 5, 2019
| github.com/cespare/xxhash v1.1.0/go.mod h1:XrSqR1VqqWfGrhpAt58auRo0WTKS1nRRg3ghfAqPWnc= | ||
| github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw= | ||
| github.com/coreos/bbolt v1.3.2/go.mod h1:iRUV2dpdMOn7Bo10OQBFzIJO9kkE559Wcmn+qkEiiKk= | ||
| github.com/coreos/etcd v3.3.10+incompatible/go.mod h1:uF7uidLiAD3TWHmW31ZFd/JWoc32PjwdhPthX9715RE= |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changesets:
Signedoff-by: Marko Baricevic marbar3778@yahoo.com