Skip to content

Address PR comments in PR #4002#4004

Merged
ebuchman merged 1 commit intorelease/v0.32.4from
prcomments
Sep 19, 2019
Merged

Address PR comments in PR #4002#4004
ebuchman merged 1 commit intorelease/v0.32.4from
prcomments

Conversation

@tac0turtle
Copy link
Contributor

Address comments in #4002

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@tac0turtle tac0turtle requested a review from ebuchman September 19, 2019 16:17
@tac0turtle tac0turtle self-assigned this Sep 19, 2019
@ebuchman ebuchman merged commit 0d13736 into release/v0.32.4 Sep 19, 2019
@ebuchman ebuchman deleted the prcomments branch September 19, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants