Fix linter errors thrown by unconvert, goconst, and nakedret#3960
Merged
melekes merged 5 commits intotendermint:masterfrom Sep 10, 2019
Merged
Conversation
melekes
reviewed
Sep 9, 2019
Contributor
melekes
left a comment
There was a problem hiding this comment.
Thanks for contributing to Tendermint 👍
Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3960 +/- ##
=========================================
Coverage ? 66.89%
=========================================
Files ? 219
Lines ? 18478
Branches ? 0
=========================================
Hits ? 12361
Misses ? 5192
Partials ? 925
|
tac0turtle
approved these changes
Sep 10, 2019
melekes
added a commit
that referenced
this pull request
Sep 10, 2019
This should've been a part of #3960, but I forgot about it while reviewing. A good programmer is someone who always looks both ways before crossing a one-way street. - Doug Linder
melekes
added a commit
that referenced
this pull request
Sep 10, 2019
This should've been a part of #3960, but I forgot about it while reviewing. A good programmer is someone who always looks both ways before crossing a one-way street. - Doug Linder
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR repairs linter errors seen when running the following commands:
golangci-lint run --no-config --disable-all=true --enable=unconvertgolangci-lint run --no-config --disable-all=true --enable=goconstgolangci-lint run --no-config --disable-all=true --enable=nakedretContributes to #3262