enable unconvert, goconst and nakedret linters#3973
Merged
Conversation
This should've been a part of #3960, but I forgot about it while reviewing. A good programmer is someone who always looks both ways before crossing a one-way street. - Doug Linder
tac0turtle
approved these changes
Sep 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #3973 +/- ##
==========================================
+ Coverage 66.91% 66.94% +0.03%
==========================================
Files 219 219
Lines 18486 18486
==========================================
+ Hits 12369 12375 +6
+ Misses 5193 5189 -4
+ Partials 924 922 -2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should've been a part of
#3960, but I forgot about
it while reviewing.
A good programmer is someone who always looks both ways before crossing
a one-way street. - Doug Linder