Don't use omitempty #3882
Description
Types which are generated from proto files in go have JSON annotations which contain omitempty for all keys, for example:
tendermint/abci/types/types.proto
Lines 137 to 145 in 62f97a6
Results in this:
tendermint/abci/types/types.pb.go
Lines 1711 to 1720 in 62f97a6
Which means if you just make empty ResponseInfo{} and serialize it to JSON you would get empty JSON object, or if you do not set some field that field will be omitted from resulting JSON.
On the other hand, types defined by hand in go don't use omitempty at all, all this results in inconsistency. As some fields are in json all the time and some aren't, it makes writing parsers of request/response types unnecessarily harder in other statically typed languages.