feat(allocator)!: rename `Box` and `Vec` methods by overlookmotel · Pull Request #21395 · oxc-project/oxc

overlookmotel · 2026-04-13T18:14:18Z

Rename Box and Vec methods which contained the word "bump", in line with renaming Bump to Arena (#21394).

No substantive changes, only renaming.

overlookmotel · 2026-04-13T18:14:37Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-04-13T18:20:59Z

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing om/04-13-refactor_allocator_rename_box_and_vec_methods (24fb7eb) with main (2e144c2)²}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (24fb7eb) during the generation of this report, so 2e144c2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Pull request overview

This PR aligns allocator APIs with the Bump → Arena rename by removing “bump” terminology from Box/Vec conversion method names across the codebase.

Changes:

Rename allocator conversion helpers from into_bump_slice* to into_arena_slice* (and update call sites).
Update formatter internals to use the renamed into_arena_slice APIs.
Update allocator tests to use the renamed methods.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/oxc_linter/src/lib.rs	Updates token extraction to use `into_arena_slice_mut`.
crates/oxc_formatter/src/print/call_like_expression/arguments.rs	Switches formatting buffer slice conversions to `into_arena_slice`.
crates/oxc_formatter/src/formatter/format_element/mod.rs	Updates interning/best-fitting storage to `into_arena_slice`.
crates/oxc_formatter/src/formatter/format_element/document.rs	Stores document elements via `into_arena_slice`.
crates/oxc_formatter/src/formatter/builders.rs	Updates best-fitting variant buffering to `into_arena_slice`.
crates/oxc_allocator/src/vec2/mod.rs	Renames `Vec` slice conversion APIs to `into_arena_slice*` and updates examples.
crates/oxc_allocator/src/vec.rs	Updates public arena `Vec` wrappers to call `into_arena_slice*`.
crates/oxc_allocator/src/boxed.rs	Renames `Box<[T]>` slice conversion APIs to `into_arena_slice*` and updates tests.

graphite-app · 2026-04-13T18:32:23Z

Merge activity

Apr 13, 6:32 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Apr 13, 6:38 PM UTC: Merged by the Graphite merge queue.

Rename `Box` and `Vec` methods which contained the word "bump", in line with renaming `Bump` to `Arena` (#21394). No substantive changes, only renaming.

### 💥 BREAKING CHANGES - 24fb7eb allocator: [**BREAKING**] Rename `Box` and `Vec` methods (#21395) (overlookmotel) ### 🚀 Features - ce5072d parser: Support `turbopack` magic comments (#20803) (Kane Wang) - f5deb55 napi/transform: Expose `optimizeConstEnums` and `optimizeEnums` options (#21388) (Dunqing) - 24b03de data_structures: Introduce `NonNullConst` and `NonNullMut` pointer types (#21425) (overlookmotel) ### 🐛 Bug Fixes - d7a359a ecmascript: Treat update expressions as unconditionally side-effectful (#21456) (Dunqing) - 56af2f4 transformer/async-to-generator: Correct scope of inferred named FE in async-to-generator (#21458) (Dunqing) - b3ed467 minifier: Avoid illegal `var;` when folding unused arguments copy loop (#21421) (fazba) - b0e8f13 minifier: Preserve `var` inside `catch` with same-named parameter (#21366) (Dunqing) - 4fb73a7 transformer/typescript: Preserve execution order for accessor with `useDefineForClassFields: false` (#21369) (Dunqing) ### ⚡ Performance - da3cc16 parser: Refactor out `LexerContext` (#21275) (Ulrich Stark) ### 📚 Documentation - c5b19bb allocator: Reformat comments in `Arena` (#21448) (overlookmotel) - 091e88e lexer: Update doc comment about perf benefit of reading through references (#21423) (overlookmotel) - 922cbee allocator: Remove references to "bump" from comments (#21397) (overlookmotel) Co-authored-by: Dunqing <29533304+Dunqing@users.noreply.github.com>

# Oxlint ### 💥 BREAKING CHANGES - 24fb7eb allocator: [**BREAKING**] Rename `Box` and `Vec` methods (#21395) (overlookmotel) ### 🚀 Features - 38d8090 linter/jest: Implemented jest `version` settings in config file. (#21522) (Said Atrahouch) - 7dbbb99 linter/eslint: Implement suggestion for `no-case-declarations` rule (#21508) (Mikhail Baev) - 9b4d9f6 linter/prefer-template: Implement autofix (#21502) (François) - daa64ed linter/no-empty-pattern: Add `allowObjectPatternsAsParameters` option (#21474) (camc314) - cf2d281 linter/typescript: Implement explicit-member-accessibility (#21447) (Hunter Tunnicliff) - d48de6f linter/unicorn: Add help messages to 3 rule diagnostics (#21459) (Mukunda Rao Katta) - cffdc2e linter: Backfill rule version metadata (#21391) (Old Autumn) ### 🐛 Bug Fixes - 1e69b91 linter/no-useless-assignment: Improve diagnostic spans (#21581) (camc314) - f272594 linter/plugins: Align `RuleMeta.replacedBy` type with ESLint (#21544) (bab) - 4d57851 linter/eslint: Enhance `no-empty-function` rule to support async and generator functions in VariableDeclarator (#21542) (Mikhail Baev) - 00fc136 codegen: Preserve coverage comments before object properties (#21312) (bab) - a56b7b9 oxlint: Dont enable gitlab formatter by default (#21501) (camc314) - 9c9b6a2 linter/array-callback-return: Ignore non-exit CFG dead ends (#21497) (camc314) - 61088e0 linter/unicorn: Handle computed property access in `prefer-dom-node-remove` rule (#21470) (Mikhail Baev) - eab5934 linter: Report an error on unsupported `extends` values (#21406) (John Costa) - 3289ba0 linter/valid-expect-in-promise: Check a jest fn to be `test` instead of `describe` (#21422) (Said Atrahouch) - 4417fe3 linter/prefer-ending-with-an-expect: Ignore vi.mock factory callbacks (#21414) (Cédric Exbrayat) - a904883 linter/consistent-type-imports: Ignore vue/svelte/astro files (#21415) (bab) - 2498fe6 linter/no-unused-vars: Allow segments of dotted namespace declarations (#21416) (bab) - 44b5b35 linter: Preserve vitest-compatible jest rules when applying overrides (#21389) (Cameron) - 7bd8331 linter/prefer-ending-with-an-expect: Add missing `version` docs (#21390) (Said Atrahouch) - 43d8f0d linter/no-useless-assignment: Ignore writes read by closures (#21380) (camc314) ### 📚 Documentation - c1eeae3 linter: Add version to `rule.json` (#21547) (camchenry) - 0ec6ab2 linter: Improve the `vitest/no-importing-vitest-globals` rule documentation. (#21557) (connorshea) # Oxfmt ### 💥 BREAKING CHANGES - 24fb7eb allocator: [**BREAKING**] Rename `Box` and `Vec` methods (#21395) (overlookmotel) ### 🚀 Features - 5aa7fe1 oxfmt: Add `--disable-nested-config` CLI flag (#21514) (leaysgur) - b5cb8d1 oxfmt: Update prettier to 3.8.3 (#21451) (leaysgur) - 16713d5 oxfmt/cli: Support per-directory config (#21103) (leaysgur) - 952de06 oxfmt/lsp: Support per-directory config (#21081) (leaysgur) ### 🐛 Bug Fixes - a501a53 formatter: Handle comments after pipe in single-member union types (#21487) (John Costa) - 6f49fad oxfmt: Respect nested config.`ignorePatterns` (#21489) (leaysgur) - 7c98d52 oxfmt: Do not panic on finding invalid nested config (#21461) (leaysgur) - 41bb2d5 formatter: Preserve more `intrinsic` parens (#21449) (leaysgur) - f894750 formatter: Preserve parens around `intrinsic` in type alias annotation (#21410) (Dunqing) ### ⚡ Performance - df27b48 oxfmt: Skip ancestors check when no nested config found (#21517) (leaysgur) - 5e1522a oxfmt: Do not occupy the rayon thread solely for handover (#21408) (leaysgur) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

overlookmotel mentioned this pull request Apr 13, 2026

docs(allocator): remove references to "bump" from comments #21397

Merged

This was referenced Apr 13, 2026

refactor(allocator): rename bump module to arena #21396

Merged

refactor(allocator): rename Bump to Arena #21394

Merged

github-actions Bot added A-linter Area - Linter A-formatter Area - Formatter A-allocator Area - Allocator C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 13, 2026

overlookmotel changed the title ~~refactor(allocator): rename Box and Vec methods~~ feat(allocator)!: rename Box and Vec methods Apr 13, 2026

github-actions Bot added the C-enhancement Category - New feature or request label Apr 13, 2026

overlookmotel self-assigned this Apr 13, 2026

overlookmotel marked this pull request as ready for review April 13, 2026 18:17

overlookmotel requested review from Dunqing, camc314 and leaysgur as code owners April 13, 2026 18:17

Copilot AI review requested due to automatic review settings April 13, 2026 18:17

Copilot started reviewing on behalf of overlookmotel April 13, 2026 18:18 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread crates/oxc_allocator/src/vec2/mod.rs

Comment thread crates/oxc_allocator/src/vec2/mod.rs

overlookmotel mentioned this pull request Apr 13, 2026

test(allocator): fix compile fail doctest #21400

Merged

feat(allocator)!: rename Box and Vec methods (#21395)

24fb7eb

Rename `Box` and `Vec` methods which contained the word "bump", in line with renaming `Bump` to `Arena` (#21394). No substantive changes, only renaming.

graphite-app Bot force-pushed the om/04-13-refactor_allocator_rename_bump_to_arena_ branch from 7163641 to f9c4f29 Compare April 13, 2026 18:33

graphite-app Bot force-pushed the om/04-13-refactor_allocator_rename_box_and_vec_methods branch from ca55ff5 to 24fb7eb Compare April 13, 2026 18:33

Base automatically changed from om/04-13-refactor_allocator_rename_bump_to_arena_ to main April 13, 2026 18:37

graphite-app Bot merged commit 24fb7eb into main Apr 13, 2026
36 checks passed

graphite-app Bot deleted the om/04-13-refactor_allocator_rename_box_and_vec_methods branch April 13, 2026 18:38

Boshen mentioned this pull request Apr 15, 2026

release(crates): oxc v0.126.0 #21471

Merged

Dunqing mentioned this pull request Apr 17, 2026

fix(isolated_declarations): drop required type check for private parameter properties on private constructors #21515

Merged

2 tasks

Dunqing mentioned this pull request Apr 17, 2026

fix(isolated_declarations): collect types from private accessors for paired inference #21516

Merged

2 tasks

This was referenced Apr 20, 2026

release(apps): oxlint v1.61.0 && oxfmt v0.46.0 #21573

Closed

release(apps): oxlint v1.61.0 && oxfmt v0.46.0 #21583

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(allocator)!: rename `Box` and `Vec` methods#21395

feat(allocator)!: rename `Box` and `Vec` methods#21395
graphite-app[bot] merged 1 commit intomainfrom
om/04-13-refactor_allocator_rename_box_and_vec_methods

overlookmotel commented Apr 13, 2026 •

edited

Loading

Uh oh!

overlookmotel commented Apr 13, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Apr 13, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

graphite-app Bot commented Apr 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

overlookmotel commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

graphite-app Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

overlookmotel commented Apr 13, 2026 •

edited

Loading

overlookmotel commented Apr 13, 2026 •

edited

Loading

codspeed-hq Bot commented Apr 13, 2026 •

edited

Loading

graphite-app Bot commented Apr 13, 2026 •

edited

Loading