refactor(allocator): rename bump module to arena#21396
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 13, 2026
Merged
refactor(allocator): rename bump module to arena#21396graphite-app[bot] merged 1 commit intomainfrom
bump module to arena#21396graphite-app[bot] merged 1 commit intomainfrom
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 13, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors oxc_allocator to rename the internal bump module and associated test paths/imports to arena, aligning naming with “arena allocator” terminology while keeping behavior the same.
Changes:
- Renamed
bumpmodule imports/usages toarenaacross allocator code and doctest examples. - Renamed/updated integration test imports and the
[[test]]entry frombump_try_alloctoarena_try_alloc. - Moved/renamed the allocator test suite directory from
tests/bump/*totests/arena/*(including the quickcheck helper module).
Reviewed changes
Copilot reviewed 22 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/oxc_allocator/Cargo.toml | Renames the [[test]] target to arena_try_alloc and updates testing-feature comment text. |
| crates/oxc_allocator/src/lib.rs | Switches conditional module exposure from bump to arena under the testing feature. |
| crates/oxc_allocator/src/arena.rs | Updates doctest imports from oxc_allocator::bump to oxc_allocator::arena. |
| crates/oxc_allocator/src/alloc.rs | Updates internal Arena import path to crate::arena::Arena. |
| crates/oxc_allocator/src/allocator.rs | Updates internal Arena import path to crate::arena::Arena. |
| crates/oxc_allocator/src/allocator_api2.rs | Updates safety comment reference from bump.rs to arena.rs. |
| crates/oxc_allocator/src/from_raw_parts.rs | Updates internal constants/types import path from bump to arena. |
| crates/oxc_allocator/src/hash_map.rs | Updates internal Arena import path to crate::arena::Arena. |
| crates/oxc_allocator/src/hash_set.rs | Updates internal Arena import path to crate::arena::Arena. |
| crates/oxc_allocator/src/tracking.rs | Updates internal Arena import path to crate::arena::Arena. |
| crates/oxc_allocator/src/vec.rs | Updates internal Arena import path to crate::arena::Arena. |
| crates/oxc_allocator/src/vec2/raw_vec.rs | Updates test-only Arena import path to crate::arena::Arena. |
| crates/oxc_allocator/tests/arena_try_alloc.rs | Updates integration test import path from oxc_allocator::bump to oxc_allocator::arena. |
| crates/oxc_allocator/tests/arena/main.rs | Test-suite crate root for the arena tests directory (module declarations + crate-level lint config). |
| crates/oxc_allocator/tests/arena/quickcheck.rs | Adds/relocates quickcheck wrapper macro for Miri-friendly iteration limiting. |
| crates/oxc_allocator/tests/arena/quickchecks.rs | Updates Arena import path to oxc_allocator::arena::Arena. |
| crates/oxc_allocator/tests/arena/tests.rs | Updates Arena import path to oxc_allocator::arena::Arena. |
| crates/oxc_allocator/tests/arena/alloc_fill.rs | Updates Arena import path to oxc_allocator::arena::Arena. |
| crates/oxc_allocator/tests/arena/alloc_try_with.rs | Updates Arena import path to oxc_allocator::arena::Arena. |
| crates/oxc_allocator/tests/arena/alloc_with.rs | Updates Arena import path to oxc_allocator::arena::Arena. |
| crates/oxc_allocator/tests/arena/allocation_limit.rs | Updates Arena import path to oxc_allocator::arena::Arena. |
| crates/oxc_allocator/tests/arena/capacity.rs | Updates Arena import path to oxc_allocator::arena::Arena. |
| crates/oxc_allocator/tests/arena/try_alloc_try_with.rs | Updates Arena import path to oxc_allocator::arena::Arena. |
| crates/oxc_allocator/tests/arena/try_alloc_with.rs | Updates Arena import path to oxc_allocator::arena::Arena. |
Contributor
Merge activity
|
ca55ff5 to
24fb7eb
Compare
91e8d4f to
80ba06d
Compare
Base automatically changed from
om/04-13-refactor_allocator_rename_box_and_vec_methods
to
main
April 13, 2026 18:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Rename
bump.rstoarena.rs, and renamebumptests directory toarena- in line with renamingBumptoArena(#21394).No substantive changes, only renaming.