Skip to content

docs(allocator): remove references to "bump" from comments#21397

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-13-docs_allocator_remove_references_to_bump_from_comments
Apr 13, 2026
Merged

docs(allocator): remove references to "bump" from comments#21397
graphite-app[bot] merged 1 commit intomainfrom
om/04-13-docs_allocator_remove_references_to_bump_from_comments

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 13, 2026

Comments only changes. Remove the word "bump" from a bunch of comments. Also remove a few references to bumpalo from Arena's doc comments.

Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 13, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-allocator Area - Allocator C-docs Category - Documentation. Related to user-facing or internal documentation labels Apr 13, 2026
@overlookmotel overlookmotel self-assigned this Apr 13, 2026
@overlookmotel overlookmotel marked this pull request as ready for review April 13, 2026 18:20
Copilot AI review requested due to automatic review settings April 13, 2026 18:20
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 13, 2026

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/04-13-docs_allocator_remove_references_to_bump_from_comments (922cbee) with main (2e144c2)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (922cbee) during the generation of this report, so 2e144c2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates documentation/comments to remove “bump”/bumpalo wording and align terminology around “arena” allocation within the allocator-related code.

Changes:

  • Renames “bump allocator” references to “arena allocator” in task output/docs.
  • Updates allocator crate docs to remove bumpalo link references and “bump” phrasing.
  • Tweaks doc examples and rustdoc links in Arena documentation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tasks/track_memory_allocations/src/lib.rs Updates comments to refer to “arena allocator” instead of “bump allocator”.
crates/oxc_allocator/src/vec2/mod.rs Rewords module docs to “arena allocator”.
crates/oxc_allocator/src/arena.rs Rewords Arena docs away from “bump” and replaces bumpalo references with oxc_allocator ones.

Comment thread crates/oxc_allocator/src/arena.rs
Comment thread crates/oxc_allocator/src/vec2/mod.rs
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Apr 13, 2026

Merge activity

Comments only changes. Remove the word "bump" from a bunch of comments. Also remove a few references to `bumpalo` from `Arena`'s doc comments.
@graphite-app graphite-app Bot force-pushed the om/04-13-refactor_allocator_rename_bump_module_to_arena_ branch from 91e8d4f to 80ba06d Compare April 13, 2026 18:34
@graphite-app graphite-app Bot force-pushed the om/04-13-docs_allocator_remove_references_to_bump_from_comments branch from 2e0a1ae to 922cbee Compare April 13, 2026 18:34
Base automatically changed from om/04-13-refactor_allocator_rename_bump_module_to_arena_ to main April 13, 2026 18:39
@graphite-app graphite-app Bot merged commit 922cbee into main Apr 13, 2026
36 checks passed
@graphite-app graphite-app Bot deleted the om/04-13-docs_allocator_remove_references_to_bump_from_comments branch April 13, 2026 18:40
Dunqing added a commit that referenced this pull request Apr 16, 2026
### 💥 BREAKING CHANGES

- 24fb7eb allocator: [**BREAKING**] Rename `Box` and `Vec` methods
(#21395) (overlookmotel)

### 🚀 Features

- ce5072d parser: Support `turbopack` magic comments (#20803) (Kane
Wang)
- f5deb55 napi/transform: Expose `optimizeConstEnums` and
`optimizeEnums` options (#21388) (Dunqing)
- 24b03de data_structures: Introduce `NonNullConst` and `NonNullMut`
pointer types (#21425) (overlookmotel)

### 🐛 Bug Fixes

- d7a359a ecmascript: Treat update expressions as unconditionally
side-effectful (#21456) (Dunqing)
- 56af2f4 transformer/async-to-generator: Correct scope of inferred
named FE in async-to-generator (#21458) (Dunqing)
- b3ed467 minifier: Avoid illegal `var;` when folding unused arguments
copy loop (#21421) (fazba)
- b0e8f13 minifier: Preserve `var` inside `catch` with same-named
parameter (#21366) (Dunqing)
- 4fb73a7 transformer/typescript: Preserve execution order for accessor
with `useDefineForClassFields: false` (#21369) (Dunqing)

### ⚡ Performance

- da3cc16 parser: Refactor out `LexerContext` (#21275) (Ulrich Stark)

### 📚 Documentation

- c5b19bb allocator: Reformat comments in `Arena` (#21448)
(overlookmotel)
- 091e88e lexer: Update doc comment about perf benefit of reading
through references (#21423) (overlookmotel)
- 922cbee allocator: Remove references to "bump" from comments (#21397)
(overlookmotel)

Co-authored-by: Dunqing <29533304+Dunqing@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-allocator Area - Allocator C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants