Skip to content

feat(linter): Implemented version for jest settings in config file.#21522

Merged
camc314 merged 4 commits intooxc-project:mainfrom
Afsoon:linter-jest-version-in-config
Apr 20, 2026
Merged

feat(linter): Implemented version for jest settings in config file.#21522
camc314 merged 4 commits intooxc-project:mainfrom
Afsoon:linter-jest-version-in-config

Conversation

@Afsoon
Copy link
Copy Markdown
Contributor

@Afsoon Afsoon commented Apr 17, 2026

AI Disclosure

This PR has been done without AI assistance

Summary

jest/no-deprecated-function don't have a config at rule level, his informations comes from the config file. I have move this value to OxlintSettings, this is the first step to add the remaining jest configs. Tester now allows a eslint config when the rule depends on config values.

Talked in discord, the current approach is config level has more priority than rule config. Added a message mentioning that rule config will be eliminated at some point.

@github-actions github-actions Bot added A-linter Area - Linter A-cli Area - CLI C-enhancement Category - New feature or request labels Apr 17, 2026
@Afsoon Afsoon changed the title feat(linter): Move jest config version from rule to config file feat(linter): Move jest config version from jest/no-deprecated-functions to config file Apr 17, 2026
@Afsoon Afsoon changed the title feat(linter): Move jest config version from jest/no-deprecated-functions to config file feat(linter): Move jest config version from jest/no-deprecated-functions to config file Apr 17, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 17, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 47 skipped benchmarks1


Comparing Afsoon:linter-jest-version-in-config (f84068d) with main (510e344)2

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (f272594) during the generation of this report, so 510e344 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Afsoon added 2 commits April 20, 2026 09:28
…`no-deprecated-functions` rule

- Tester fix now accepts a eslint config parameter.
- The default jest version is 29, as before in the rule.
- Accepts version as integer and string.
…ype for jest version

This avoid to dereference it always we want to compare the value
@Afsoon Afsoon force-pushed the linter-jest-version-in-config branch from 82ad3c5 to d2643e3 Compare April 20, 2026 07:29
@Afsoon Afsoon marked this pull request as ready for review April 20, 2026 07:30
@Afsoon Afsoon requested a review from camc314 as a code owner April 20, 2026 07:30
@Afsoon Afsoon changed the title feat(linter): Move jest config version from jest/no-deprecated-functions to config file feat(linter): Implemented version for jest settings in config file. Apr 20, 2026
@Afsoon Afsoon force-pushed the linter-jest-version-in-config branch from d2643e3 to b93d1ec Compare April 20, 2026 07:36
Copy link
Copy Markdown
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@camc314 camc314 merged commit 38d8090 into oxc-project:main Apr 20, 2026
27 checks passed
@camc314 camc314 self-assigned this Apr 20, 2026
camc314 added a commit that referenced this pull request Apr 20, 2026
# Oxlint
### 💥 BREAKING CHANGES

- 24fb7eb allocator: [**BREAKING**] Rename `Box` and `Vec` methods
(#21395) (overlookmotel)

### 🚀 Features

- 38d8090 linter/jest: Implemented jest `version` settings in config
file. (#21522) (Said Atrahouch)
- 7dbbb99 linter/eslint: Implement suggestion for `no-case-declarations`
rule (#21508) (Mikhail Baev)
- 9b4d9f6 linter/prefer-template: Implement autofix (#21502) (François)
- daa64ed linter/no-empty-pattern: Add `allowObjectPatternsAsParameters`
option (#21474) (camc314)
- cf2d281 linter/typescript: Implement explicit-member-accessibility
(#21447) (Hunter Tunnicliff)
- d48de6f linter/unicorn: Add help messages to 3 rule diagnostics
(#21459) (Mukunda Rao Katta)
- cffdc2e linter: Backfill rule version metadata (#21391) (Old Autumn)

### 🐛 Bug Fixes

- 1e69b91 linter/no-useless-assignment: Improve diagnostic spans
(#21581) (camc314)
- f272594 linter/plugins: Align `RuleMeta.replacedBy` type with ESLint
(#21544) (bab)
- 4d57851 linter/eslint: Enhance `no-empty-function` rule to support
async and generator functions in VariableDeclarator (#21542) (Mikhail
Baev)
- 00fc136 codegen: Preserve coverage comments before object properties
(#21312) (bab)
- a56b7b9 oxlint: Dont enable gitlab formatter by default (#21501)
(camc314)
- 9c9b6a2 linter/array-callback-return: Ignore non-exit CFG dead ends
(#21497) (camc314)
- 61088e0 linter/unicorn: Handle computed property access in
`prefer-dom-node-remove` rule (#21470) (Mikhail Baev)
- eab5934 linter: Report an error on unsupported `extends` values
(#21406) (John Costa)
- 3289ba0 linter/valid-expect-in-promise: Check a jest fn to be `test`
instead of `describe` (#21422) (Said Atrahouch)
- 4417fe3 linter/prefer-ending-with-an-expect: Ignore vi.mock factory
callbacks (#21414) (Cédric Exbrayat)
- a904883 linter/consistent-type-imports: Ignore vue/svelte/astro files
(#21415) (bab)
- 2498fe6 linter/no-unused-vars: Allow segments of dotted namespace
declarations (#21416) (bab)
- 44b5b35 linter: Preserve vitest-compatible jest rules when applying
overrides (#21389) (Cameron)
- 7bd8331 linter/prefer-ending-with-an-expect: Add missing `version`
docs (#21390) (Said Atrahouch)
- 43d8f0d linter/no-useless-assignment: Ignore writes read by closures
(#21380) (camc314)

### 📚 Documentation

- c1eeae3 linter: Add version to `rule.json` (#21547) (camchenry)
- 0ec6ab2 linter: Improve the `vitest/no-importing-vitest-globals` rule
documentation. (#21557) (connorshea)
# Oxfmt
### 💥 BREAKING CHANGES

- 24fb7eb allocator: [**BREAKING**] Rename `Box` and `Vec` methods
(#21395) (overlookmotel)

### 🚀 Features

- 5aa7fe1 oxfmt: Add `--disable-nested-config` CLI flag (#21514)
(leaysgur)
- b5cb8d1 oxfmt: Update prettier to 3.8.3 (#21451) (leaysgur)
- 16713d5 oxfmt/cli: Support per-directory config (#21103) (leaysgur)
- 952de06 oxfmt/lsp: Support per-directory config (#21081) (leaysgur)

### 🐛 Bug Fixes

- a501a53 formatter: Handle comments after pipe in single-member union
types (#21487) (John Costa)
- 6f49fad oxfmt: Respect nested config.`ignorePatterns` (#21489)
(leaysgur)
- 7c98d52 oxfmt: Do not panic on finding invalid nested config (#21461)
(leaysgur)
- 41bb2d5 formatter: Preserve more `intrinsic` parens (#21449)
(leaysgur)
- f894750 formatter: Preserve parens around `intrinsic` in type alias
annotation (#21410) (Dunqing)

### ⚡ Performance

- df27b48 oxfmt: Skip ancestors check when no nested config found
(#21517) (leaysgur)
- 5e1522a oxfmt: Do not occupy the rayon thread solely for handover
(#21408) (leaysgur)

Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants