feat(oxfmt/lsp): Support per-directory config by leaysgur · Pull Request #21081 · oxc-project/oxc

leaysgur · 2026-04-06T07:31:31Z

A.k.a. nested config, for LSP.

I plan to add CLI support later, LSP support for start.
(So, please do not merge for a while. 🙏🏻)

Before: At startup, it finds-up for config file starting from the workspace root
- It followed the same behavior as the CLI
After: When a formatting request is made, it finds-up for a config file starting from the target file and then caches
- Unlike Oxlint, Oxfmt does not have the concept of a root config, so this approach is sufficient
- In the first place, I don't see any reason to parse a config file when you don't even know if it's going to be used
Unchanged:
- It still resolves a single .prettierignore and .editorconfig as before
- When configPath is specified, it uses only that config file
- For in-memory file, it is resolved by workspace root

leaysgur · 2026-04-06T07:31:44Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sysix

I did not test, only looked at the source code what looks "weird" for me :)
In general the code looks great. Thank you 👍

leaysgur · 2026-04-07T01:40:39Z

Thanks~! I've addressed.
ConcurrentHashMap is good..., I was impressed by how much shorter the code became!

Sysix

Looks great ❤️
After testing it with VS Code and looking deeper into your changes, I only have 2 notices/questions :)

EDIT: oh I see why you did it this way. So we do not need to clear cache upwards directories.

leaysgur · 2026-04-09T01:18:42Z

Thank you! 😉

Then, I'll freeze the code for now.
It's going to take a bit more time before we can merge it. As long as #20416 remains unresolved, we're bound to see frequent errors where vite.config.ts is detected during the find-up process...

graphite-app · 2026-04-15T01:24:44Z

Merge activity

Apr 15, 1:24 AM UTC: leaysgur added this pull request to the Graphite merge queue.
Apr 15, 1:30 AM UTC: Merged by the Graphite merge queue.

A.k.a. nested config, for LSP. I plan to add CLI support later, LSP support for start. (So, please do not merge for a while. 🙏🏻) - Before: At startup, it finds-up for config file starting from the workspace root - It followed the same behavior as the CLI - After: When a formatting request is made, it finds-up for a config file starting from the target file and then caches - Unlike Oxlint, Oxfmt does not have the concept of a root config, so this approach is sufficient - In the first place, I don't see any reason to parse a config file when you don't even know if it's going to be used - Unchanged: - It still resolves a single `.prettierignore` and `.editorconfig` as before - When `configPath` is specified, it uses only that config file - For in-memory file, it is resolved by workspace root

# Oxlint ### 💥 BREAKING CHANGES - 24fb7eb allocator: [**BREAKING**] Rename `Box` and `Vec` methods (#21395) (overlookmotel) ### 🚀 Features - 38d8090 linter/jest: Implemented jest `version` settings in config file. (#21522) (Said Atrahouch) - 7dbbb99 linter/eslint: Implement suggestion for `no-case-declarations` rule (#21508) (Mikhail Baev) - 9b4d9f6 linter/prefer-template: Implement autofix (#21502) (François) - daa64ed linter/no-empty-pattern: Add `allowObjectPatternsAsParameters` option (#21474) (camc314) - cf2d281 linter/typescript: Implement explicit-member-accessibility (#21447) (Hunter Tunnicliff) - d48de6f linter/unicorn: Add help messages to 3 rule diagnostics (#21459) (Mukunda Rao Katta) - cffdc2e linter: Backfill rule version metadata (#21391) (Old Autumn) ### 🐛 Bug Fixes - 1e69b91 linter/no-useless-assignment: Improve diagnostic spans (#21581) (camc314) - f272594 linter/plugins: Align `RuleMeta.replacedBy` type with ESLint (#21544) (bab) - 4d57851 linter/eslint: Enhance `no-empty-function` rule to support async and generator functions in VariableDeclarator (#21542) (Mikhail Baev) - 00fc136 codegen: Preserve coverage comments before object properties (#21312) (bab) - a56b7b9 oxlint: Dont enable gitlab formatter by default (#21501) (camc314) - 9c9b6a2 linter/array-callback-return: Ignore non-exit CFG dead ends (#21497) (camc314) - 61088e0 linter/unicorn: Handle computed property access in `prefer-dom-node-remove` rule (#21470) (Mikhail Baev) - eab5934 linter: Report an error on unsupported `extends` values (#21406) (John Costa) - 3289ba0 linter/valid-expect-in-promise: Check a jest fn to be `test` instead of `describe` (#21422) (Said Atrahouch) - 4417fe3 linter/prefer-ending-with-an-expect: Ignore vi.mock factory callbacks (#21414) (Cédric Exbrayat) - a904883 linter/consistent-type-imports: Ignore vue/svelte/astro files (#21415) (bab) - 2498fe6 linter/no-unused-vars: Allow segments of dotted namespace declarations (#21416) (bab) - 44b5b35 linter: Preserve vitest-compatible jest rules when applying overrides (#21389) (Cameron) - 7bd8331 linter/prefer-ending-with-an-expect: Add missing `version` docs (#21390) (Said Atrahouch) - 43d8f0d linter/no-useless-assignment: Ignore writes read by closures (#21380) (camc314) ### 📚 Documentation - c1eeae3 linter: Add version to `rule.json` (#21547) (camchenry) - 0ec6ab2 linter: Improve the `vitest/no-importing-vitest-globals` rule documentation. (#21557) (connorshea) # Oxfmt ### 💥 BREAKING CHANGES - 24fb7eb allocator: [**BREAKING**] Rename `Box` and `Vec` methods (#21395) (overlookmotel) ### 🚀 Features - 5aa7fe1 oxfmt: Add `--disable-nested-config` CLI flag (#21514) (leaysgur) - b5cb8d1 oxfmt: Update prettier to 3.8.3 (#21451) (leaysgur) - 16713d5 oxfmt/cli: Support per-directory config (#21103) (leaysgur) - 952de06 oxfmt/lsp: Support per-directory config (#21081) (leaysgur) ### 🐛 Bug Fixes - a501a53 formatter: Handle comments after pipe in single-member union types (#21487) (John Costa) - 6f49fad oxfmt: Respect nested config.`ignorePatterns` (#21489) (leaysgur) - 7c98d52 oxfmt: Do not panic on finding invalid nested config (#21461) (leaysgur) - 41bb2d5 formatter: Preserve more `intrinsic` parens (#21449) (leaysgur) - f894750 formatter: Preserve parens around `intrinsic` in type alias annotation (#21410) (Dunqing) ### ⚡ Performance - df27b48 oxfmt: Skip ancestors check when no nested config found (#21517) (leaysgur) - 5e1522a oxfmt: Do not occupy the rayon thread solely for handover (#21408) (leaysgur) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions Bot added A-cli Area - CLI A-editor Area - Editor and Language Server A-formatter Area - Formatter C-enhancement Category - New feature or request labels Apr 6, 2026

leaysgur force-pushed the 04-06-feat_oxfmt_lsp_support_per-directory_config branch from 67a8247 to 1971927 Compare April 6, 2026 08:12

leaysgur requested a review from Sysix April 6, 2026 08:14

leaysgur force-pushed the 04-06-feat_oxfmt_lsp_support_per-directory_config branch from 1971927 to ea0c32b Compare April 6, 2026 08:17

leaysgur mentioned this pull request Apr 6, 2026

refactor(oxfmt): Rework glob expansion #21083

Merged

Sysix reviewed Apr 6, 2026

View reviewed changes

Comment thread apps/oxfmt/src/lsp/server_formatter.rs Outdated

Comment thread apps/oxfmt/src/lsp/server_formatter.rs Outdated

Comment thread apps/oxfmt/src/lsp/server_formatter.rs Outdated

leaysgur requested a review from Sysix April 7, 2026 01:40

leaysgur force-pushed the 04-06-feat_oxfmt_lsp_support_per-directory_config branch 2 times, most recently from eae912f to 5449f52 Compare April 7, 2026 02:10

leaysgur mentioned this pull request Apr 7, 2026

feat(oxfmt/cli): Support per-directory config #21103

Merged

leaysgur force-pushed the 04-06-feat_oxfmt_lsp_support_per-directory_config branch from 5449f52 to d65c03c Compare April 7, 2026 04:41

leaysgur changed the base branch from main to graphite-base/21081 April 7, 2026 05:18

leaysgur force-pushed the 04-06-feat_oxfmt_lsp_support_per-directory_config branch from d65c03c to a59e81e Compare April 7, 2026 05:18

leaysgur changed the base branch from graphite-base/21081 to 04-06-refactor_oxfmt_rework_glob_expansion April 7, 2026 05:19

leaysgur force-pushed the 04-06-refactor_oxfmt_rework_glob_expansion branch from 8b38451 to bb040ce Compare April 7, 2026 06:24

leaysgur force-pushed the 04-06-feat_oxfmt_lsp_support_per-directory_config branch from a59e81e to e668056 Compare April 7, 2026 06:24

leaysgur force-pushed the 04-06-refactor_oxfmt_rework_glob_expansion branch from bb040ce to 1065731 Compare April 7, 2026 06:41

leaysgur force-pushed the 04-06-feat_oxfmt_lsp_support_per-directory_config branch from e668056 to 1429737 Compare April 7, 2026 06:41

graphite-app Bot changed the base branch from 04-06-refactor_oxfmt_rework_glob_expansion to graphite-base/21081 April 7, 2026 06:59

graphite-app Bot force-pushed the graphite-base/21081 branch from 1065731 to 85075ce Compare April 7, 2026 07:03

graphite-app Bot force-pushed the 04-06-feat_oxfmt_lsp_support_per-directory_config branch from 1429737 to 06b72bd Compare April 7, 2026 07:03

graphite-app Bot changed the base branch from graphite-base/21081 to main April 7, 2026 07:04

graphite-app Bot force-pushed the 04-06-feat_oxfmt_lsp_support_per-directory_config branch from 06b72bd to 75cf93b Compare April 7, 2026 07:04

leaysgur force-pushed the 04-06-feat_oxfmt_lsp_support_per-directory_config branch 2 times, most recently from c7dce6a to 821bbc3 Compare April 8, 2026 03:41

Sysix reviewed Apr 8, 2026

View reviewed changes

Comment thread apps/oxfmt/src/lsp/server_formatter.rs

Comment thread apps/oxfmt/src/lsp/server_formatter.rs

Sysix approved these changes Apr 8, 2026

View reviewed changes

leaysgur force-pushed the 04-06-feat_oxfmt_lsp_support_per-directory_config branch 4 times, most recently from 120980e to 6b3cf4f Compare April 13, 2026 09:02

Sysix mentioned this pull request Apr 13, 2026

formatter/lsp: overrides in .oxfmtrc.json not applied when formatting via VS Code extension #21385

Closed

leaysgur force-pushed the 04-06-feat_oxfmt_lsp_support_per-directory_config branch from 6b3cf4f to 076ce9a Compare April 14, 2026 00:31

This was referenced Apr 14, 2026

refactor(oxfmt): Rename cli/format -> cli/runner #21407

Merged

perf(oxfmt): Do not occupy the rayon thread solely for handover #21408

Merged

refactor(oxfmt): Sync num of walker threads by --threads #21409

Merged

graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Apr 15, 2026

graphite-app Bot force-pushed the 04-06-feat_oxfmt_lsp_support_per-directory_config branch from 076ce9a to 952de06 Compare April 15, 2026 01:26

graphite-app Bot merged commit 952de06 into main Apr 15, 2026
24 checks passed

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 15, 2026

graphite-app Bot deleted the 04-06-feat_oxfmt_lsp_support_per-directory_config branch April 15, 2026 01:30

This was referenced Apr 20, 2026

release(apps): oxlint v1.61.0 && oxfmt v0.46.0 #21573

Closed

release(apps): oxlint v1.61.0 && oxfmt v0.46.0 #21583

Merged

camchenry mentioned this pull request Apr 23, 2026

feat(oxfmt): support nested .oxfmtrc.json configs for monorepos #20062

Closed

7 tasks

Sysix mentioned this pull request Apr 29, 2026

oxfmt/lsp: Oxfmt LSP does not work for repos where the frontend app is in a subdirectory #18781

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(oxfmt/lsp): Support per-directory config#21081

feat(oxfmt/lsp): Support per-directory config#21081
graphite-app[bot] merged 1 commit intomainfrom
04-06-feat_oxfmt_lsp_support_per-directory_config

leaysgur commented Apr 6, 2026 •

edited

Loading

Uh oh!

leaysgur commented Apr 6, 2026 •

edited

Loading

Uh oh!

Sysix left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leaysgur commented Apr 7, 2026

Uh oh!

Sysix left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

leaysgur commented Apr 9, 2026

Uh oh!

graphite-app Bot commented Apr 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

leaysgur commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leaysgur commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Sysix left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leaysgur commented Apr 7, 2026

Uh oh!

Sysix left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

leaysgur commented Apr 9, 2026

Uh oh!

graphite-app Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

leaysgur commented Apr 6, 2026 •

edited

Loading

leaysgur commented Apr 6, 2026 •

edited

Loading

Sysix left a comment •

edited

Loading

graphite-app Bot commented Apr 15, 2026 •

edited

Loading