fix(linter/no-useless-assignment): ignore writes read by closures by camc314 · Pull Request #21380 · oxc-project/oxc

camc314 · 2026-04-13T11:33:07Z

No description provided.

camc314 · 2026-04-13T11:33:20Z

fix(linter/no-useless-assignment): ignore writes read by closures #21380 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

camc314 · 2026-04-13T11:36:01Z

Merge activity

Apr 13, 11:36 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Apr 13, 11:38 AM UTC: camc314 added this pull request to the Graphite merge queue.
Apr 13, 11:39 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #21379.
Apr 13, 11:39 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #21379.
Apr 13, 11:39 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Apr 13, 11:40 AM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
Apr 13, 11:41 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Apr 13, 11:41 AM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
Apr 13, 11:43 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Apr 13, 11:44 AM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
Apr 13, 4:08 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Apr 13, 4:09 PM UTC: camc314 added this pull request to the Graphite merge queue.
Apr 13, 4:16 PM UTC: Merged by the Graphite merge queue.

Copilot

Pull request overview

Updates the eslint/no-useless-assignment rule implementation to avoid flagging assignments as “useless” when the assigned variable is read from a captured closure (i.e., read in a different parent variable scope), which can be invoked later and therefore makes the assignment semantically observable.

Changes:

Track symbols that are read from a different parent variable scope (closure-captured reads) during reference collection.
Suppress “useless assignment” diagnostics for writes to symbols that have closure-captured reads.
Add new passing test cases covering closure reads (stored callback, exported API closure, and IIFE closure).

codspeed-hq · 2026-04-13T11:39:34Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 47 skipped benchmarks¹

_{Comparing c/04-13-fix_linter_no-useless-assignment_ignore_writes_read_by_closures (5a07578) with main (e16848e)²}

47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (c019750) during the generation of this report, so e16848e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

…1380)

# Oxlint ### 💥 BREAKING CHANGES - 24fb7eb allocator: [**BREAKING**] Rename `Box` and `Vec` methods (#21395) (overlookmotel) ### 🚀 Features - 38d8090 linter/jest: Implemented jest `version` settings in config file. (#21522) (Said Atrahouch) - 7dbbb99 linter/eslint: Implement suggestion for `no-case-declarations` rule (#21508) (Mikhail Baev) - 9b4d9f6 linter/prefer-template: Implement autofix (#21502) (François) - daa64ed linter/no-empty-pattern: Add `allowObjectPatternsAsParameters` option (#21474) (camc314) - cf2d281 linter/typescript: Implement explicit-member-accessibility (#21447) (Hunter Tunnicliff) - d48de6f linter/unicorn: Add help messages to 3 rule diagnostics (#21459) (Mukunda Rao Katta) - cffdc2e linter: Backfill rule version metadata (#21391) (Old Autumn) ### 🐛 Bug Fixes - 1e69b91 linter/no-useless-assignment: Improve diagnostic spans (#21581) (camc314) - f272594 linter/plugins: Align `RuleMeta.replacedBy` type with ESLint (#21544) (bab) - 4d57851 linter/eslint: Enhance `no-empty-function` rule to support async and generator functions in VariableDeclarator (#21542) (Mikhail Baev) - 00fc136 codegen: Preserve coverage comments before object properties (#21312) (bab) - a56b7b9 oxlint: Dont enable gitlab formatter by default (#21501) (camc314) - 9c9b6a2 linter/array-callback-return: Ignore non-exit CFG dead ends (#21497) (camc314) - 61088e0 linter/unicorn: Handle computed property access in `prefer-dom-node-remove` rule (#21470) (Mikhail Baev) - eab5934 linter: Report an error on unsupported `extends` values (#21406) (John Costa) - 3289ba0 linter/valid-expect-in-promise: Check a jest fn to be `test` instead of `describe` (#21422) (Said Atrahouch) - 4417fe3 linter/prefer-ending-with-an-expect: Ignore vi.mock factory callbacks (#21414) (Cédric Exbrayat) - a904883 linter/consistent-type-imports: Ignore vue/svelte/astro files (#21415) (bab) - 2498fe6 linter/no-unused-vars: Allow segments of dotted namespace declarations (#21416) (bab) - 44b5b35 linter: Preserve vitest-compatible jest rules when applying overrides (#21389) (Cameron) - 7bd8331 linter/prefer-ending-with-an-expect: Add missing `version` docs (#21390) (Said Atrahouch) - 43d8f0d linter/no-useless-assignment: Ignore writes read by closures (#21380) (camc314) ### 📚 Documentation - c1eeae3 linter: Add version to `rule.json` (#21547) (camchenry) - 0ec6ab2 linter: Improve the `vitest/no-importing-vitest-globals` rule documentation. (#21557) (connorshea) # Oxfmt ### 💥 BREAKING CHANGES - 24fb7eb allocator: [**BREAKING**] Rename `Box` and `Vec` methods (#21395) (overlookmotel) ### 🚀 Features - 5aa7fe1 oxfmt: Add `--disable-nested-config` CLI flag (#21514) (leaysgur) - b5cb8d1 oxfmt: Update prettier to 3.8.3 (#21451) (leaysgur) - 16713d5 oxfmt/cli: Support per-directory config (#21103) (leaysgur) - 952de06 oxfmt/lsp: Support per-directory config (#21081) (leaysgur) ### 🐛 Bug Fixes - a501a53 formatter: Handle comments after pipe in single-member union types (#21487) (John Costa) - 6f49fad oxfmt: Respect nested config.`ignorePatterns` (#21489) (leaysgur) - 7c98d52 oxfmt: Do not panic on finding invalid nested config (#21461) (leaysgur) - 41bb2d5 formatter: Preserve more `intrinsic` parens (#21449) (leaysgur) - f894750 formatter: Preserve parens around `intrinsic` in type alias annotation (#21410) (Dunqing) ### ⚡ Performance - df27b48 oxfmt: Skip ancestors check when no nested config found (#21517) (leaysgur) - 5e1522a oxfmt: Do not occupy the rayon thread solely for handover (#21408) (leaysgur) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

camc314 mentioned this pull request Apr 13, 2026

fix(linter/no-useless-assignment): handle across continue edges #21379

Closed

github-actions Bot added A-linter Area - Linter C-bug Category - Bug labels Apr 13, 2026

camc314 self-assigned this Apr 13, 2026

camc314 added the 0-merge Merge with Graphite Merge Queue label Apr 13, 2026

camc314 marked this pull request as ready for review April 13, 2026 11:34

Copilot AI review requested due to automatic review settings April 13, 2026 11:34

Copilot started reviewing on behalf of camc314 April 13, 2026 11:35 View session

graphite-app Bot changed the base branch from c/04-13-fix_linter_no-useless-assignment_handle_across_continue_edges to graphite-base/21380 April 13, 2026 11:37

Copilot AI reviewed Apr 13, 2026

View reviewed changes

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 13, 2026

camc314 force-pushed the graphite-base/21380 branch from 1893d31 to e16848e Compare April 13, 2026 12:00

camc314 force-pushed the c/04-13-fix_linter_no-useless-assignment_ignore_writes_read_by_closures branch from 36d4bfe to a329898 Compare April 13, 2026 12:00

camc314 changed the base branch from graphite-base/21380 to main April 13, 2026 12:00

camc314 marked this pull request as draft April 13, 2026 12:00

camc314 marked this pull request as ready for review April 13, 2026 15:43

camc314 requested a review from Copilot April 13, 2026 15:43

Copilot started reviewing on behalf of camc314 April 13, 2026 15:44 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread crates/oxc_linter/src/rules/eslint/no_useless_assignment.rs Outdated

camc314 added the 0-merge Merge with Graphite Merge Queue label Apr 13, 2026

fix(linter/no-useless-assignment): ignore writes read by closures (#2…

43d8f0d

…1380)

graphite-app Bot force-pushed the c/04-13-fix_linter_no-useless-assignment_ignore_writes_read_by_closures branch from 5a07578 to 43d8f0d Compare April 13, 2026 16:10

graphite-app Bot merged commit 43d8f0d into main Apr 13, 2026
26 checks passed

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 13, 2026

graphite-app Bot deleted the c/04-13-fix_linter_no-useless-assignment_ignore_writes_read_by_closures branch April 13, 2026 16:16

This was referenced Apr 20, 2026

release(apps): oxlint v1.61.0 && oxfmt v0.46.0 #21573

Closed

release(apps): oxlint v1.61.0 && oxfmt v0.46.0 #21583

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(linter/no-useless-assignment): ignore writes read by closures#21380

fix(linter/no-useless-assignment): ignore writes read by closures#21380
graphite-app[bot] merged 1 commit intomainfrom
c/04-13-fix_linter_no-useless-assignment_ignore_writes_read_by_closures

camc314 commented Apr 13, 2026

Uh oh!

camc314 commented Apr 13, 2026 •

edited

Loading

Uh oh!

camc314 commented Apr 13, 2026 •

edited by graphite-app Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

codspeed-hq Bot commented Apr 13, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

camc314 commented Apr 13, 2026

Uh oh!

camc314 commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

camc314 commented Apr 13, 2026 • edited by graphite-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

codspeed-hq Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camc314 commented Apr 13, 2026 •

edited

Loading

camc314 commented Apr 13, 2026 •

edited by graphite-app Bot

Loading

codspeed-hq Bot commented Apr 13, 2026 •

edited

Loading