Skip to content

refactor(oxfmt): Rework glob expansion#21083

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-06-refactor_oxfmt_rework_glob_expansion
Apr 7, 2026
Merged

refactor(oxfmt): Rework glob expansion#21083
graphite-app[bot] merged 1 commit intomainfrom
04-06-refactor_oxfmt_rework_glob_expansion

Conversation

@leaysgur
Copy link
Copy Markdown
Member

@leaysgur leaysgur commented Apr 6, 2026

  • Before: Resolved beforehand and treated as a simple list of paths
    • = 2-pass
  • After: Walked through like a standard path, with processing handled by a custom matcher
    • = 1-pass
    • To support per-directory config, we need to locate the config files during the directory walk; glob is no exception

This is an internal change and generally has no impact on users.
(In niche cases, the content of the log output will change, but it will result in more consistent.)

Copy link
Copy Markdown
Member Author

leaysgur commented Apr 6, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-cli Area - CLI A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 6, 2026
@leaysgur leaysgur force-pushed the 04-06-feat_oxfmt_lsp_support_per-directory_config branch from ea0c32b to eae912f Compare April 7, 2026 01:41
@leaysgur leaysgur force-pushed the 04-06-refactor_oxfmt_rework_glob_expansion branch 2 times, most recently from 3be1888 to 97c5d0b Compare April 7, 2026 02:10
@leaysgur leaysgur force-pushed the 04-06-feat_oxfmt_lsp_support_per-directory_config branch from eae912f to 5449f52 Compare April 7, 2026 02:10
@leaysgur leaysgur force-pushed the 04-06-feat_oxfmt_lsp_support_per-directory_config branch from 5449f52 to d65c03c Compare April 7, 2026 04:41
@leaysgur leaysgur force-pushed the 04-06-refactor_oxfmt_rework_glob_expansion branch from 97c5d0b to 480b393 Compare April 7, 2026 04:41
@leaysgur leaysgur changed the base branch from 04-06-feat_oxfmt_lsp_support_per-directory_config to graphite-base/21083 April 7, 2026 05:18
@leaysgur leaysgur force-pushed the graphite-base/21083 branch from d65c03c to af7bff0 Compare April 7, 2026 05:18
@leaysgur leaysgur force-pushed the 04-06-refactor_oxfmt_rework_glob_expansion branch from 480b393 to 8b38451 Compare April 7, 2026 05:18
@leaysgur leaysgur changed the base branch from graphite-base/21083 to main April 7, 2026 05:18
@leaysgur leaysgur marked this pull request as ready for review April 7, 2026 05:21
@leaysgur leaysgur force-pushed the 04-06-refactor_oxfmt_rework_glob_expansion branch 2 times, most recently from bb040ce to 1065731 Compare April 7, 2026 06:41
@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Apr 7, 2026
Copy link
Copy Markdown
Member Author

leaysgur commented Apr 7, 2026

Merge activity

- Before: Resolved beforehand and treated as a simple list of paths
  - = 2-pass
- After: Walked through like a standard path, with processing handled by a custom matcher
  - = 1-pass
  - To support per-directory config, we need to locate the config files during the directory walk; glob is no exception

This is an internal change and generally has no impact on users.
(In niche cases, the content of the log output will change, but it will result in more consistent.)
@graphite-app graphite-app Bot force-pushed the 04-06-refactor_oxfmt_rework_glob_expansion branch from 1065731 to 85075ce Compare April 7, 2026 06:59
@graphite-app graphite-app Bot merged commit 85075ce into main Apr 7, 2026
24 checks passed
@graphite-app graphite-app Bot deleted the 04-06-refactor_oxfmt_rework_glob_expansion branch April 7, 2026 07:03
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant